fix parsing of python-platform in settings tomls
#12592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serde needs to be told where to put underscores. someone clearly noticed this when adding attributes for schemars, but they need to be present for serde too and then schemars gets them for free. Strictly speaking this is a breaking change for anyone who noticed the parsing was messed up and worked around it. We could add aliases for backcompat if we care.
Gankra
changed the title
python-platform in settings tomls
charliermarsh
approved these changes
Apr 1, 2025
|
Aliases added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde needs to be told where to put underscores. someone clearly noticed this when adding attributes for schemars, but they need to be present for serde too and then schemars gets them for free.
Strictly speaking this would be a breaking change for anyone who noticed the parsing was messed up and worked around it. So we add aliases for backcompat, at least for a few releases.
Fixes #12590