Propagate credentials for `<index>/simple` to `<index>/...` endpoints #11074

zanieb · 2025-01-29T17:52:31Z

Sort of an minimal implementation of #4583

crates/uv-distribution-types/src/index.rs

A test case for #11074 (and related issues)

zanieb · 2025-01-29T21:53:52Z

crates/uv/src/commands/build_frontend.rs

+            let credentials = Arc::new(credentials);
+            uv_auth::store_credentials(index.raw_url(), credentials.clone());
+            if let Some(root_url) = index.root_url() {
+                uv_auth::store_credentials(&root_url, credentials.clone());
+            }


We could omit raw_url() in favor of root_url() but I think this is "safer"

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.25` -> `0.5.27` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.27`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0527) [Compare Source](astral-sh/uv@0.5.26...0.5.27) ##### Enhancements - Avoid setting permissions during tar extraction ([#11191](astral-sh/uv#11191)) - Remove warnings for missing lower bounds ([#11195](astral-sh/uv#11195)) - Update PubGrub to set-based outdated priority tracking ([#11169](astral-sh/uv#11169)) - Improve error messages for `uv pip install` with `--extra` or `--all-extras` and invalid sources ([#11193](astral-sh/uv#11193)) - Sign Docker images using GitHub attestations ([#8685](astral-sh/uv#8685)) ##### Preview features - Don't expand self-referential extras in the build backend ([#11142](astral-sh/uv#11142)) ##### Performance - Filter discovered Python executables by source before querying ([#11143](astral-sh/uv#11143)) - Optimize exclusion computation for markers ([#11158](astral-sh/uv#11158)) - Use Astral-maintained `tokio-tar` fork ([#11174](astral-sh/uv#11174)) - Remove unneeded `.clone()` ([#11127](astral-sh/uv#11127)) ##### Bug fixes - Fix relative paths in bytecode compilation ([#11177](astral-sh/uv#11177)) - Percent-decode URLs in canonical comparisons ([#11088](astral-sh/uv#11088)) - Respect concurrency limits in parallel index fetch ([#11182](astral-sh/uv#11182)) - Use wire JSON schema for conflict items ([#11196](astral-sh/uv#11196)) - Use explicit `_GLibCVersion` tuple in uv-python crate ([#11122](astral-sh/uv#11122)) ##### Documentation - Add Git SHA locking behavior to docs ([#11125](astral-sh/uv#11125)) - Add best-practice flags to `pip install` example in troubleshooting guide ([#11194](astral-sh/uv#11194)) - Set `VIRTUAL_ENV` in Jupyter kernels ([#11155](astral-sh/uv#11155)) - Add instructions for deactivating an environment ([#11200](astral-sh/uv#11200)) ### [`v0.5.26`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0526) [Compare Source](astral-sh/uv@0.5.25...0.5.26) ##### Enhancements - Add support for `uvx python` ([#11076](astral-sh/uv#11076)) - Allow `--no-dev --invert` in `uv tree` ([#11068](astral-sh/uv#11068)) - Update `uv python install --reinstall` to reinstall all previous versions ([#11072](astral-sh/uv#11072)) - Consistently write log messages with capitalized first word ([#11111](astral-sh/uv#11111)) - Suggest `--build-backend` when `--backend` is passed to `uv init` ([#10958](astral-sh/uv#10958)) - Improve retry trace message ([#11108](astral-sh/uv#11108)) ##### Performance - Remove unnecessary UTF-8 conversion in hash parsing ([#11110](astral-sh/uv#11110)) ##### Bug fixes - Ignore non-hash fragments in HTML API responses ([#11107](astral-sh/uv#11107)) - Avoid resolving symbolic links when querying Python interpreters ([#11083](astral-sh/uv#11083)) - Avoid sharing state between universal and non-universal resolves ([#11051](astral-sh/uv#11051)) - Error when `--script` is passing a non-PEP 723 script ([#11118](astral-sh/uv#11118)) - Make metadata deserialization failures non-fatal in the cache ([#11105](astral-sh/uv#11105)) - Mark metadata as dynamic when reading from built wheel cache ([#11046](astral-sh/uv#11046)) - Propagate credentials for `<index>/simple` to `<index>/...` endpoints ([#11074](astral-sh/uv#11074)) - Fix conflicting extra bug during `uv sync` ([#11075](astral-sh/uv#11075)) ##### Documentation - Add PyTorch XPU instructions to the PyTorch guide ([#11109](astral-sh/uv#11109)) - Add docs for signal handling ([#11041](astral-sh/uv#11041)) - Explain build frontend vs. build backend ([#11094](astral-sh/uv#11094)) - Fix formatting of `RUST_LOG` documentation ([#10053](astral-sh/uv#10053)) - Fix typo in `--no-deps` description ([#11073](astral-sh/uv#11073)) - Reflow CLI documentation comments ([#11040](astral-sh/uv#11040)) - Shorten "Using existing Python versions" nav item so it fits on one line ([#11077](astral-sh/uv#11077)) - Some minor touch-ups to the Python install guide ([#11116](astral-sh/uv#11116)) - Update Dependabot tracking issue link ([#11054](astral-sh/uv#11054)) - Update documentation for running in a container ([#11052](astral-sh/uv#11052)) - Upgrade PyTorch version in documentation ([#11114](astral-sh/uv#11114)) - Use `sys_platform` in lieu of `platform_system` in PyTorch docs ([#11113](astral-sh/uv#11113)) - Use positive (rather than negative) markers in PyTorch examples ([#11112](astral-sh/uv#11112)) - Fix unnecessary backslashes in brackets ([#11059](astral-sh/uv#11059)) - Suggest setting copy link mode in GitLab integration guide ([#11067](astral-sh/uv#11067)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

jzazo · 2025-02-10T16:19:08Z

Hi! It says at the beginning it's sort of minimal implementation for #4583. We have latest uv version and we can still not install packages with 401 authentication errors, problem being that package url's are queried. Should this PR fix that issue, or still unsolved? Thank you.

zanieb · 2025-02-10T16:20:36Z

@jzazo Do you have a trailing / on your URL? #11336 is not released yet

jzazo · 2025-02-10T16:26:58Z

uv tries with a URL where there is a trailing /, ending in .../_packaging/MI/pypi/simple/. But I think uv did not try that URL but this one instead: .../_packaging/MI/pypi/simple/poetry-core/ (not sure why trying to locate poetry, might be a relic).

zanieb · 2025-02-10T16:43:35Z

If you remove the trailing / from your index URL config, it should work.

zanieb · 2025-02-10T16:44:33Z

Though it doesn't really make sense that this would fix a request to .../_packaging/MI/pypi/simple/poetry-core/ since it's not at .../simple/../... like ..../files/.

It'd probably be better to just open an issue.. way easier to tell what's going on with all the details.

zanieb added the bug Something isn't working label Jan 29, 2025

zanieb commented Jan 29, 2025

View reviewed changes

crates/uv-distribution-types/src/index.rs Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

zanieb mentioned this pull request Jan 29, 2025

Unable to add packages from several private sources #11017

Closed

zanieb force-pushed the zb/files-index branch from 3344405 to 39d55cf Compare January 29, 2025 19:07

zanieb changed the title ~~Pre-emptively store credentials for /files endpoints in /simple index URLs~~ Propagate credentials for <index>/simple to <index>/... endpoints Jan 29, 2025

zanieb mentioned this pull request Jan 29, 2025

Add test case for multiple indexes on the same realm #11080

Merged

zanieb added a commit that referenced this pull request Jan 29, 2025

Add test case for multiple indexes on the same realm (#11080)

ae76a4b

A test case for #11074 (and related issues)

Propagate credentials for <index>/simple to <index>/... endpoints

dfe65ed

zanieb force-pushed the zb/files-index branch from 39d55cf to dfe65ed Compare January 29, 2025 20:47

zanieb marked this pull request as ready for review January 29, 2025 21:52

zanieb commented Jan 29, 2025

View reviewed changes

charliermarsh approved these changes Jan 30, 2025

View reviewed changes

zanieb merged commit 1dfa650 into main Jan 30, 2025
73 checks passed

zanieb deleted the zb/files-index branch January 30, 2025 16:22

BrewTestBot mentioned this pull request Jan 30, 2025

uv 0.5.26 Homebrew/homebrew-core#206081

Merged

This was referenced Feb 5, 2025

Issue with uv pip Handling Multiple Private Index URLs Leading to 403 Errors #11244

Closed

uv add with multiple (extra-)index-urls fails #9741

Closed

jzazo mentioned this pull request Feb 10, 2025

Index URL cannot be queried for lack of authentication ending with package name #11391

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate credentials for `<index>/simple` to `<index>/...` endpoints #11074

Propagate credentials for `<index>/simple` to `<index>/...` endpoints #11074

zanieb commented Jan 29, 2025 •

edited

Loading

This comment was marked as outdated.

zanieb Jan 29, 2025

jzazo commented Feb 10, 2025

zanieb commented Feb 10, 2025 •

edited

Loading

jzazo commented Feb 10, 2025 •

edited

Loading

zanieb commented Feb 10, 2025

zanieb commented Feb 10, 2025

Propagate credentials for <index>/simple to <index>/... endpoints #11074

Propagate credentials for <index>/simple to <index>/... endpoints #11074

Conversation

zanieb commented Jan 29, 2025 • edited Loading

This comment was marked as outdated.

zanieb Jan 29, 2025

Choose a reason for hiding this comment

jzazo commented Feb 10, 2025

zanieb commented Feb 10, 2025 • edited Loading

jzazo commented Feb 10, 2025 • edited Loading

zanieb commented Feb 10, 2025

zanieb commented Feb 10, 2025

Propagate credentials for `<index>/simple` to `<index>/...` endpoints #11074

Propagate credentials for `<index>/simple` to `<index>/...` endpoints #11074

zanieb commented Jan 29, 2025 •

edited

Loading

zanieb commented Feb 10, 2025 •

edited

Loading

jzazo commented Feb 10, 2025 •

edited

Loading