Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce build and check times #5711

Open
zanieb opened this issue Aug 1, 2024 · 1 comment
Open

Reduce build and check times #5711

zanieb opened this issue Aug 1, 2024 · 1 comment
Labels
help wanted Contribution especially encouraged tracking A "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues.

Comments

@zanieb
Copy link
Member

zanieb commented Aug 1, 2024

I can update this with some concrete timing information, but cargo build and cargo clippy times are on the rise as the project grows. This is a tracking issue to improve the situation and discuss sources of slowness.

@zanieb zanieb added help wanted Contribution especially encouraged tracking A "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues. labels Aug 1, 2024
@zanieb
Copy link
Member Author

zanieb commented Aug 1, 2024

Anyone is welcome to get involved here, this is a great way to improve the health of the project without deep knowledge of Python packaging.

fasterthanlime added a commit to bearcove/uv that referenced this issue Sep 6, 2024
charliermarsh pushed a commit that referenced this issue Sep 6, 2024
(This is part of #5711)

## Summary

@BurntSushi and I spotted that the `derivative` crate is only used for
one enum in the entire codebase — however, it's a proc macro, and we pay
for the cost of (re)compiling it in many different contexts.

This replaces it with a private `Inner` core which uses the regular std
derive macros — inlining and optimizations should make this equivalent
to the other implementation, and not too hard to maintain hopefully
(versus a manual impl of `PartialEq` and `Hash` which have to be kept in
sync.)

## Test Plan

Trust CI?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contribution especially encouraged tracking A "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues.
Projects
None yet
Development

No branches or pull requests

1 participant