Conversation
| TAG=$(jq -r '.announcement_tag // .tag' "$MANIFEST") | ||
| TITLE=$(jq -r '.announcement_title' "$MANIFEST") | ||
| BODY=$(jq -r '.announcement_github_body' "$MANIFEST") | ||
| PRERELEASE=$(jq -r '.announcement_is_prerelease' "$MANIFEST") |
There was a problem hiding this comment.
This might be a problematic line too? I'm not sure we should omit it unless we reproduce the problem though. Also, I think no part of this script is repo specific, so we should probably just put it in it's own repo or a gist and link to it in CONTRIBUTING?
There was a problem hiding this comment.
I think it was just the later line with the echo that was messed up
There was a problem hiding this comment.
Regardless of where we add it. Can we add a mention to CONTRIBUTING.md that this script exist and when/how to use it
|
We have the shellcheck hook enabled in Ruff's pre-commit config but not in this repo — it might be an idea to add it here too if we're adding more shell scripts. It's really good at checking for syntax issues and common mistakes in shell scripts. https://github.com/astral-sh/ruff/blob/7319c37f4eb063e9590e1f09c8e92d7dabc63403/.pre-commit-config.yaml#L134 |
## Summary See: #2385 (comment)
|
I think we should just close this for now; we can revive it in the event that we need to proceed with a manual release in the future. |
5 participants
Same one in uv but with the prerelease line delete because @zanieb noted it was broken