feat: add OS version to cache key to prevent binary incompatibility #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds OS name and version (e.g., ubuntu-22.04, macos-14, windows-2022) to the cache key to prevent binary incompatibility issues when GitHub runner images change. Changes: - Add getOSNameVersion() to detect OS name and version - Include OS version in cache key (bump CACHE_VERSION to 2) - Add cache-key output for debugging and testing - Add test-cache-key-os-version workflow job - Update test-musl to verify alpine in cache key - Document cache key components in docs/caching.md Closes #703
eifinger
force-pushed
the
os-version-in-cache-key
branch
from
9f4dde8 to
b7255b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-22.04,macos-14,windows-2022) to cache keys to prevent binary incompatibility when GitHub updates runner imagesChanges
getOSNameVersion()function tosrc/utils/platforms.tswith OS-specific detection for Linux (via/etc/os-release), macOS (Darwin kernel version mapping), and WindowsCACHE_VERSIONto"2"cache-keyoutput to expose the generated cache key for debuggingtest-cache-key-os-versionjob testing across multiple OS versionsdocs/caching.mdwith cache key documentationCloses #703