Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv in rye build when enabled #978

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Apr 1, 2024

The build package supports uv since version 1.2.0 - it can use either uv or pip as installer.

The main way to use it would be to install build[uv] but rye already has uv installed separately, build will find it on the path as a fallback, so this can work for rye.

build is implicitly tested by test_publish.

Relates to #668

rye/src/cli/build.rs Outdated Show resolved Hide resolved
@bluss bluss force-pushed the build-with-uv branch 3 times, most recently from 3238f14 to a07df52 Compare April 1, 2024 12:39
@bluss bluss marked this pull request as ready for review April 1, 2024 12:59
The `build` package supports uv since version 1.2.0 - it can use either
uv or pip as installer.

The main way to use it would be to install `build[uv]` but rye already
has uv installed separately, build will find it on the path as a
fallback, so this can work for rye.
Also new in build 1.2.0, it supports the --verbose flag.
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@charliermarsh charliermarsh merged commit c62d0f4 into astral-sh:main Apr 24, 2024
8 checks passed
@bluss bluss deleted the build-with-uv branch April 24, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants