rye add argument checking #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without some restriction, `rye add --path foo` would previously run as a successful command that does nothing, which is confusing for the user. The simplest way forward right now is to require at least one requirement or dependency.
Don't allow `rye add --path ./x x y` or similar, these arguments make sense with one requirement only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without some restriction,
rye add --path foowould previously run as asuccessful command that does nothing, which is confusing for the user.
Always require >= 1 requirement in add and remove.
Don't allow
rye add --path ./x x yor similar, these arguments makesense with one requirement only.
I'm not sure if there is a nicer way of reporting argument errors here
than using
bail!().