Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover cosmo-ified (.com) binaries on Windows #1091

Merged
merged 1 commit into from
May 20, 2024
Merged

Discover cosmo-ified (.com) binaries on Windows #1091

merged 1 commit into from
May 20, 2024

Conversation

mataha
Copy link
Contributor

@mataha mataha commented May 18, 2024

Executables compiled with Cosmopolitan libc runtime have a .com extension on Windows. This includes cosmo-ified Python binaries.

Example here.

Executables compiled with Cosmopolitan libc runtime have a `.com` extension
on Windows. This includes cosmo-ified Python binaries.
@zanieb
Copy link
Member

zanieb commented May 18, 2024

Hi! Did you confirm that these work once discovered?

@zanieb
Copy link
Member

zanieb commented May 18, 2024

And is there a reason they can't use the system standard executable suffix?

@mataha
Copy link
Contributor Author

mataha commented May 18, 2024

Hi! Did you confirm that these work once discovered?

Python works, which is good enough for me. I was hoping that scripts would work as well, but these report "program not found" as std::process::Command is used under the hood with all of its shortcomings.

And is there a reason they can't use the system standard executable suffix?

It's to distinguish them from the standard PE executable format. That said, Windows itself bundles some .com binaries for compatibility purposes (more being the most egregious example) even though they're PE.

@charliermarsh charliermarsh merged commit 8074daa into astral-sh:main May 20, 2024
8 checks passed
@mataha
Copy link
Contributor Author

mataha commented May 21, 2024

Thanks!

@mataha mataha deleted the fix/cosmo branch May 21, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants