Allow to generate lockfiles with hashes when using uv. #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
May 10, 2024
This was an oversight... We should keep the behavior backwards compatible. Sadly we cannot test hashes because there are not compatible PEP508 (pep505-rs).
|
Thanks for the quick review. I fixed the failing tests. |
|
The Test (Window) is failing due to an access denied. I think this is probably not related to the PR. |
|
Looks like a spurious failure -- re-ran and it succeeded. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the option
--generate-hashesto bothrye syncandrye lock. It will generate lock files with hashes if usinguv.