Fix Rye not using user-chosen toolchain as default during installation #1054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Currently:
ensure_self_venv_with_toolchain
to bootstrap rye internals it would pass thetoolchain_version_request
variable as the version to installRYE_TOOLCHAIN_VERSION
env var is not set, then the value oftoolchain_version_request
remains Noneprompt_for_default_toolchain
is called to prompt the user for a version to select, asking the user"Which version of Python should be used as default toolchain?"
config_doc
TOML configuration and returns nothingChanges:
toolchain_version_request
mutable so it can be updated by the user's inputprompt_for_default_toolchain
returns the resolved version that the user wants, which may be the input they typed or the default valuetoolchain_version_request
so it can be used during the internals bootstrapping