Formatter and parser refactoring #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
konstin
added
formatter
MichaReiser
reviewed
Sep 21, 2023
| Ok(formatted.print()?) | ||
| } | ||
|
|
||
| pub fn format_node<'a>( | ||
| root: &'a Mod, | ||
| pub fn format_module_ast<'a>( |
There was a problem hiding this comment.
The idea here was that you could pass any node eventually (e.g. a single statement)
There was a problem hiding this comment.
That makes sense for later, but right now e.g. the comments assume that you have the entire AST present anyway
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
I got confused and refactored a bit
konstin
force-pushed
the
_formatter-and-parser-refactorings
branch
from
1aabf59 to
dd8b124
Compare
CodSpeed Performance ReportMerging #7569 will improve performances by 8.46%Comparing Summary
Benchmarks breakdown
|
MichaReiser
reviewed
Sep 26, 2023
|
updated |
MichaReiser
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got confused and refactored a bit, now the naming should be more consistent. This is the basis for the range formatting work.
Chages:
format_module->format_module_source(format a string)format_node->format_module_ast(format a program parsed into an AST)parse_ok_tokensthat takesTokeninstead ofResult<Token>sourceconsistentlytokens_and_rangeshelperpython_ast->module(because that's the type)