-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable preview mode during benchmarks #7208
Conversation
dad2878
to
b72f962
Compare
CodSpeed Performance ReportMerging #7208 will degrade performances by 5.6%Comparing Summary
Benchmarks breakdown
|
8490cf3
to
16f830f
Compare
74e7eb1
to
6116d0e
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
Another option is to add new benchmarks for preview mode. Probably a good way to separate performance changes in preview and stable? |
8421200
to
4ea6f17
Compare
6116d0e
to
caa3a4e
Compare
Sounds good to me. Separating preview and stable benchmarks can help narrow down a regression or catch unintentional performance regressions when supposedly only changing preview code. It could then be taken off lightly as: this is preview only when in fact, we just regressed stable. |
caa3a4e
to
f060bbd
Compare
This reverts commit 9522dfb.
f060bbd
to
32e5cab
Compare
I think I'd like to include this as a general improvement and we can look for a contributor for splitting them into separate benchmarks? |
Split out of #7195 so benchmark changes from enabling additional rules can be reviewed separately.