-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in RustPython parser #6099
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
4b48762
to
6c40a51
Compare
6c40a51
to
004c8b0
Compare
seems a shame to lose the history. i think last time i did something like this i followed https://medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b (i may be misremembering the article; there are lots of tutorials online and i've successfully merged repos a few times in the past without too much trouble) |
013ffcb
to
66997bd
Compare
66997bd
to
447a923
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
Oh no, auto merge was still enabled. I wanted to look into in preserving the history |
Summary
This PR pulls in the RustPython-parser from https://github.com/astral-sh/RustPython-Parser
The reason for pulling in RustPython are:
This doesn't mean we won't contribute to the upstream parser in the future. We'll decide on upstream contributions on a case per case basis.
Another benefit of pulling in the rust python AST is that we can now define our own method on the AST types rather than needing free-standing functions or traits.
Requested Feedback
rustpython-ast
andruff_python_ast
revealed that using the parser inside ofruff_python_ast
unit tests is no longer possible because that creates a cyclic dependency. The only way around this is to either extract the tests as integration tests (what I've done here), or keep the two crates separate.Test Plan
cargo test