Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks to playground color scheme #5754

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

I kind of hate the light mode theme, but they now use colors from our actual palette:

Screen Shot 2023-07-13 at 10 15 14 PM Screen Shot 2023-07-13 at 10 15 12 PM Screen Shot 2023-07-13 at 10 15 10 PM Screen Shot 2023-07-13 at 10 15 07 PM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      8.4±0.02ms     4.8 MB/sec    1.00      8.4±0.02ms     4.9 MB/sec
formatter/numpy/ctypeslib.py               1.01   1881.9±2.49µs     8.8 MB/sec    1.00   1870.9±3.02µs     8.9 MB/sec
formatter/numpy/globals.py                 1.00    203.8±0.36µs    14.5 MB/sec    1.00    203.4±0.43µs    14.5 MB/sec
formatter/pydantic/types.py                1.03      4.2±0.01ms     6.0 MB/sec    1.00      4.1±0.02ms     6.2 MB/sec
linter/all-rules/large/dataset.py          1.04     14.8±0.06ms     2.8 MB/sec    1.00     14.2±0.05ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      3.6±0.01ms     4.6 MB/sec    1.00      3.5±0.01ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.01    385.0±3.62µs     7.7 MB/sec    1.00    382.5±1.62µs     7.7 MB/sec
linter/all-rules/pydantic/types.py         1.02      6.5±0.03ms     3.9 MB/sec    1.00      6.3±0.04ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.06      7.6±0.02ms     5.4 MB/sec    1.00      7.1±0.07ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.04   1526.9±3.10µs    10.9 MB/sec    1.00   1466.1±2.45µs    11.4 MB/sec
linter/default-rules/numpy/globals.py      1.04    161.4±0.44µs    18.3 MB/sec    1.00    155.7±0.26µs    18.9 MB/sec
linter/default-rules/pydantic/types.py     1.05      3.3±0.01ms     7.7 MB/sec    1.00      3.2±0.01ms     8.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.6±0.14ms     4.2 MB/sec    1.01      9.7±0.11ms     4.2 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.1±0.12ms     7.8 MB/sec    1.01      2.1±0.03ms     7.8 MB/sec
formatter/numpy/globals.py                 1.00    230.1±5.85µs    12.8 MB/sec    1.02   234.3±10.57µs    12.6 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.04ms     5.4 MB/sec    1.01      4.8±0.08ms     5.4 MB/sec
linter/all-rules/large/dataset.py          1.00     16.0±0.13ms     2.5 MB/sec    1.00     16.1±0.14ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.06ms     4.0 MB/sec    1.00      4.2±0.07ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.01   436.3±12.01µs     6.8 MB/sec    1.00    432.7±9.18µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.3±0.09ms     3.5 MB/sec    1.01      7.3±0.12ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.00      8.2±0.07ms     5.0 MB/sec    1.02      8.3±0.06ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1678.8±21.55µs     9.9 MB/sec    1.01  1697.3±23.40µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    181.5±2.53µs    16.3 MB/sec    1.01    183.3±2.75µs    16.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.05ms     6.9 MB/sec    1.01      3.7±0.03ms     6.9 MB/sec

@charliermarsh charliermarsh merged commit 12489d3 into main Jul 14, 2023
@charliermarsh charliermarsh deleted the charlie/play-colors branch July 14, 2023 02:37
evanrittenhouse pushed a commit to evanrittenhouse/ruff that referenced this pull request Jul 19, 2023
## Summary

I kind of hate the light mode theme, but they now use colors from our
actual palette:

<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 14 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/f1da0153-d6ed-4b65-9419-b824f2cad614">
<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 12 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/d9452e10-796b-4b7f-bf3f-7af6e0b14fc0">
<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 10 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/f75e7c1c-3b5a-4a78-8bb8-d8b4d40a337d">
<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 07 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/52c23108-b9c2-4a1f-adf0-e11098dbdc5d">
konstin pushed a commit that referenced this pull request Jul 19, 2023
## Summary

I kind of hate the light mode theme, but they now use colors from our
actual palette:

<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 14 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/f1da0153-d6ed-4b65-9419-b824f2cad614">
<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 12 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/d9452e10-796b-4b7f-bf3f-7af6e0b14fc0">
<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 10 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/f75e7c1c-3b5a-4a78-8bb8-d8b4d40a337d">
<img width="1792" alt="Screen Shot 2023-07-13 at 10 15 07 PM"
src="https://github.com/astral-sh/ruff/assets/1309177/52c23108-b9c2-4a1f-adf0-e11098dbdc5d">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant