Make columns indices 1-based in the text output format

[fsouza]

Not changing the column in JSON errors. Not sure if we want to change that too.

Closes #537.

[charliermarsh]

I think it'd make sense to change it in the JSON printer too if you're up for it. Should we even consider changing it when we convert from Check to Message, so that Message is always one-indexed?

[fsouza]

@charliermarsh good call! Let me make that change.

[fsouza]

@charliermarsh how does this look? I originally tried to make a copy of the Location directly, but the fields are private, so I ended-up copying it and then mutating with go_right().

My Rust-fu is a bit limited here, let me know if I'm wasting your time 😁

[fsouza]

this doesn't feel right 🙈

[charliermarsh]

I think you can use Location::new and location.row() methods to create a new location here! (On subway so low-fidelity message…)

[fsouza]

Ohh that makes more sense hah I was too influenced by Go in my first attempt. Pushed a fix!

[charliermarsh]

Woo, thanks!

[charliermarsh]

\cc @Seamooo - we changed Message back to one-based indexing for columns. (Check still uses zero-based indexing, so if ruffd uses Check now as planned, it will be unaffected.)

[Seamooo]

Awesome, ruffd also now uses location and end_location in Patch and this also appears unaffected