Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test performances #3774

Closed

Conversation

JonathanPlasse
Copy link
Contributor

@JonathanPlasse JonathanPlasse commented Mar 28, 2023

This PR is to check if nextest is faster.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     13.9±0.08ms     2.9 MB/sec    1.04     14.5±0.10ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.02ms     4.7 MB/sec    1.02      3.6±0.02ms     4.6 MB/sec
linter/all-rules/numpy/globals.py          1.00    462.2±1.24µs     6.4 MB/sec    1.02    472.9±0.98µs     6.2 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.9±0.02ms     4.3 MB/sec    1.03      6.1±0.03ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      7.2±0.02ms     5.7 MB/sec    1.07      7.7±0.02ms     5.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1628.5±7.40µs    10.2 MB/sec    1.04   1697.9±5.80µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    181.6±2.35µs    16.2 MB/sec    1.03    186.9±0.42µs    15.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.3±0.01ms     7.6 MB/sec    1.05      3.5±0.01ms     7.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     15.6±0.11ms     2.6 MB/sec    1.01     15.8±0.11ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.03ms     4.0 MB/sec    1.00      4.1±0.02ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.01    437.6±5.81µs     6.7 MB/sec    1.00    435.1±6.80µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.8±0.03ms     3.8 MB/sec    1.00      6.8±0.03ms     3.8 MB/sec
linter/default-rules/large/dataset.py      1.01      8.3±0.14ms     4.9 MB/sec    1.00      8.2±0.03ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1786.0±10.66µs     9.3 MB/sec    1.00  1785.3±10.62µs     9.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    186.8±1.82µs    15.8 MB/sec    1.01    188.3±3.48µs    15.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.8±0.02ms     6.7 MB/sec    1.00      3.8±0.03ms     6.7 MB/sec

@JonathanPlasse
Copy link
Contributor Author

The tests are 13 seconds faster for Linux and 54 seconds slower for Windows.
It is not worth changing to nextest.
Closing.

@JonathanPlasse JonathanPlasse deleted the improve-test-performance branch March 28, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore use of cargo nextest for test running
1 participant