Introduce a ruff_diagnostics crate
#3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/ruff-diagnostics
branch
from
9589d48 to
0dda74d
Compare
charliermarsh
force-pushed
the
charlie/ruff-diagnostics
branch
from
0dda74d to
223a95d
Compare
charliermarsh
force-pushed
the
charlie/ruff-diagnostics
branch
4 times, most recently
from
30a1130 to
f9b1973
Compare
MichaReiser
approved these changes
Mar 9, 2023
charliermarsh
force-pushed
the
charlie/ruff-diagnostics
branch
from
f9b1973 to
919dfa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
Diagnostic,DiagnosticKind, andFixinto their own crate, which will enable us to further split up Ruff, since sub-linter crates (which need to implement functions that returnDiagnostic) can now depend onruff_diagnosticsrather than Ruff.