Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade RustPython #3341

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Upgrade RustPython #3341

merged 1 commit into from
Mar 4, 2023

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 4, 2023 •
edited
Loading

Summary

Upgrades RustPython to pull in RustPython/RustPython#4623, which in turn closes #3337.

The linked PR ensures that we treat match as an identifier, and not a keyword, when assigning a lambda, like match = lambda: 1 + 1.

MichaReiser
MichaReiser approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some context to the PR about the features/bugfixes that we get with the bump (why are we interested in pulling in the new version)?

@charliermarsh
Copy link
Member Author

Done, thanks for the nudge :)

@charliermarsh charliermarsh merged commit 376ef92 into main Mar 4, 2023
@charliermarsh charliermarsh deleted the charlie/rustpython branch March 4, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing error when using match as variable name
2 participants
@charliermarsh @MichaReiser