[flake8-pyi] Rename PYI033 to legacy-type-comment

[AlexWaygood]

Summary

Rename PYI033 from type-comment-in-stub to legacy-type-comment, including the internal rule, module, and preview-helper identifiers.

The new name reflects that the rule also runs on Python files in preview mode, rather than implying that it only applies to stub files.

[AlexWaygood]

(Followup to #26129)

[astral-sh-bot]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+28 -28 violations, +0 -0 fixes in 3 projects; 53 projects unchanged)

PlasmaPy/PlasmaPy (+11 -11 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ src/plasmapy/analysis/fit_functions.py:35:36: legacy-type-comment Don't use type comments
- src/plasmapy/analysis/fit_functions.py:35:36: type-comment-in-stub Don't use type comments
+ tests/analysis/test_fit_functions.py:66:36: legacy-type-comment Don't use type comments
- tests/analysis/test_fit_functions.py:66:36: type-comment-in-stub Don't use type comments
+ tests/analysis/test_fit_functions.py:67:42: legacy-type-comment Don't use type comments
- tests/analysis/test_fit_functions.py:67:42: type-comment-in-stub Don't use type comments
+ tests/analysis/test_fit_functions.py:68:41: legacy-type-comment Don't use type comments
- tests/analysis/test_fit_functions.py:68:41: type-comment-in-stub Don't use type comments
+ tests/analysis/test_fit_functions.py:69:39: legacy-type-comment Don't use type comments
- tests/analysis/test_fit_functions.py:69:39: type-comment-in-stub Don't use type comments
+ tests/analysis/test_fit_functions.py:70:36: legacy-type-comment Don't use type comments
- tests/analysis/test_fit_functions.py:70:36: type-comment-in-stub Don't use type comments
+ tests/utils/decorators/test_checks.py:66:62: legacy-type-comment Don't use type comments
- tests/utils/decorators/test_checks.py:66:62: type-comment-in-stub Don't use type comments
+ tests/utils/decorators/test_checks.py:785:64: legacy-type-comment Don't use type comments
- tests/utils/decorators/test_checks.py:785:64: type-comment-in-stub Don't use type comments
+ tests/utils/decorators/test_validators.py:164:12: legacy-type-comment Don't use type comments
- tests/utils/decorators/test_validators.py:164:12: type-comment-in-stub Don't use type comments
+ tests/utils/decorators/test_validators.py:27:67: legacy-type-comment Don't use type comments
... 2 additional changes omitted for rule legacy-type-comment
... 3 additional changes omitted for project

apache/airflow (+12 -12 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ performance/src/performance_dags/performance_dag/performance_dag.py:131:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag.py:131:5: type-comment-in-stub Don't use type comments
+ performance/src/performance_dags/performance_dag/performance_dag.py:149:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag.py:149:5: type-comment-in-stub Don't use type comments
+ performance/src/performance_dags/performance_dag/performance_dag.py:182:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag.py:182:5: type-comment-in-stub Don't use type comments
+ performance/src/performance_dags/performance_dag/performance_dag.py:71:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag.py:71:5: type-comment-in-stub Don't use type comments
+ performance/src/performance_dags/performance_dag/performance_dag.py:84:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag.py:84:5: type-comment-in-stub Don't use type comments
+ performance/src/performance_dags/performance_dag/performance_dag_utils.py:641:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag_utils.py:641:5: type-comment-in-stub Don't use type comments
+ performance/src/performance_dags/performance_dag/performance_dag_utils.py:679:5: legacy-type-comment Don't use type comments
- performance/src/performance_dags/performance_dag/performance_dag_utils.py:679:5: type-comment-in-stub Don't use type comments
+ providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:299:45: legacy-type-comment Don't use type comments
- providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:299:45: type-comment-in-stub Don't use type comments
+ providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:362:56: legacy-type-comment Don't use type comments
- providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:362:56: type-comment-in-stub Don't use type comments
+ providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:474:56: legacy-type-comment Don't use type comments
- providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:474:56: type-comment-in-stub Don't use type comments
+ providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:49:31: legacy-type-comment Don't use type comments
... 2 additional changes omitted for rule legacy-type-comment
... 3 additional changes omitted for project

apache/superset (+5 -5 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ superset/db_engine_specs/ocient.py:100:14: legacy-type-comment Don't use type comments
- superset/db_engine_specs/ocient.py:100:14: type-comment-in-stub Don't use type comments
+ superset/db_engine_specs/ocient.py:113:13: legacy-type-comment Don't use type comments
- superset/db_engine_specs/ocient.py:113:13: type-comment-in-stub Don't use type comments
+ superset/db_engine_specs/ocient.py:126:18: legacy-type-comment Don't use type comments
- superset/db_engine_specs/ocient.py:126:18: type-comment-in-stub Don't use type comments
+ superset/db_engine_specs/ocient.py:151:15: legacy-type-comment Don't use type comments
- superset/db_engine_specs/ocient.py:151:15: type-comment-in-stub Don't use type comments
+ tests/integration_tests/superset_test_custom_template_processors.py:43:62: legacy-type-comment Don't use type comments
- tests/integration_tests/superset_test_custom_template_processors.py:43:62: type-comment-in-stub Don't use type comments

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
legacy-type-comment	28	28	0	0	0
type-comment-in-stub	28	0	28	0	0

[MichaReiser]

From a past rename PR

I think the changes here should all be backwards-compatible, but we'll need to remember to add a redirect for the documentation after the next release (whether it is a minor release or patch release).

I don't think I've the necessary permissions anymore

[ntBre]

Thank you!