Skip to content

Inline parser recovery context checks - #26038

Merged
MichaReiser merged 1 commit into
mainfrom
micha/parser-inline-recovery-context
Jun 16, 2026
Merged

Inline parser recovery context checks#26038
MichaReiser merged 1 commit into
mainfrom
micha/parser-inline-recovery-context

Conversation

@MichaReiser

Copy link
Copy Markdown
Member

Summary

Specialize recovery-context checks in hot list-parsing loops to avoid repeated context dispatch. Parser simulations reduce instructions by 1.01% and branch mispredictions by 5.45% across the suite.

@astral-sh-bot

astral-sh-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@astral-sh-bot

astral-sh-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@codspeed-hq

codspeed-hq Bot commented Jun 16, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 4.33%

⚡ 3 improved benchmarks
✅ 128 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime ty_module_resolver[125] 4 ms 3.8 ms +4.57%
WallTime ty_module_resolver[25] 1.4 ms 1.3 ms +4.36%
WallTime ty_module_resolver[600] 18.2 ms 17.5 ms +4.07%

Tip

Curious why this is faster? Use the CodSpeed MCP and ask your agent.


Comparing micha/parser-inline-recovery-context (680791d) with main (3cef341)

Open in CodSpeed

@MichaReiser MichaReiser added the parser Related to the parser label Jun 16, 2026
@MichaReiser
MichaReiser marked this pull request as ready for review June 16, 2026 13:14
@MichaReiser
MichaReiser requested a review from dhruvmanila as a code owner June 16, 2026 13:14
@MichaReiser
MichaReiser merged commit 4fda309 into main Jun 16, 2026
59 checks passed
@MichaReiser
MichaReiser deleted the micha/parser-inline-recovery-context branch June 16, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser Related to the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants