Reject yield expressions after commas - #26024
Merged
Merged
Conversation
Memory usage reportMemory usage unchanged ✅ |
|
charliermarsh
changed the title
|
dhruvmanila
approved these changes
Jun 16, 2026
Comment on lines
+358
to
+360
| // test_err yield_after_comma | ||
| // def f(): 1, yield 1 | ||
|
|
Member
There was a problem hiding this comment.
Can we add a test_ok case where the yield expression is parenthesized if it's not already present?
// test_ok yield_after_comma_parenthesized
// def f(): 1, (yield 1)
MichaReiser
removed their request for review
June 16, 2026 06:08
charliermarsh
enabled auto-merge (squash)
June 16, 2026 09:23
charliermarsh
disabled auto-merge
June 16, 2026 09:24
charliermarsh
enabled auto-merge (squash)
June 16, 2026 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject unparenthesized
yieldexpressions after the first element of an expression list:The parser previously reused the yield-enabled expression context for every tuple element. Python's grammar only allows the initial simple-statement alternative to be a
yieldexpression; later comma-separated elements use the ordinary starred-expression grammar.This clears the yield allowance for subsequent elements while preserving valid parenthesized nested yields.