Validate function type parameter default order - #25981
Merged
charliermarsh merged 1 commit intoJun 14, 2026
Merged
Conversation
charliermarsh
changed the title
Memory usage reportMemory usage unchanged ✅ |
|
|
charliermarsh
deleted the
charlie/fix-function-type-parameter-default-order
branch
June 14, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Function type parameter lists did not run the same default-order validation as class and type-alias parameter lists. As a result, we accepted functions with a required type parameter after one with a default:
This reuses the existing type-parameter ordering check for function definitions, so we now report the same semantic syntax error that we already emit for equivalent classes and type aliases.