Skip to content

Conversation

@charliecloudberry
Copy link
Contributor

Summary

Ruff support was recently added to PyCharm and I want to update Ruff's documentation accordingly.

Test Plan

n/a

@ntBre
Copy link
Contributor

ntBre commented Nov 12, 2025

My understanding based on #10102 (comment) was that the Ruff support was still in preview, and this seems to be supported by the warning at the top of the docs you linked:

Because PyCharm 2025.3 is still in development, this documentation may not be entirely accurate and is subject to change.

Should we hold off until the Ruff support is stabilized, or do most users have access to the preview features?

@ntBre ntBre added the documentation Improvements or additions to documentation label Nov 12, 2025
@charliecloudberry
Copy link
Contributor Author

@ntBre Hi! Ruff support is already available in the EAP version of PyCharm (anyone can install and use this version if they want to), and the major release is planned before the end of 2025.
Also I was not sure how long it would take for the changes to be merged and published, so I decided to submit the PR now.
If you think we should wait, I can submit my changes later.

@ntBre
Copy link
Contributor

ntBre commented Nov 12, 2025

Ah okay, I wasn't sure exactly how preview worked, thanks!

And thank you for opening this by the way, we're excited for the official support too!

If we merge this today it would go out in the weekly patch release tomorrow, though, so I would probably lean toward waiting or at least keeping the old setup instructions too until stabilization.

But I'm curious what others think too (cc @MichaReiser)

@MichaReiser
Copy link
Member

Nice! I agree with @ntBre. I'd prefer to keep the old documentation around for now and mention that the builtin Ruff integration is only available with Pycharm verison X or newer

@charliecloudberry
Copy link
Contributor Author

Hi! Thank you for the review and suggestions. I’ve restored the old documentation and updated the text to specify the PyCharm version.
I’ll also submit a new PR to update the link to the PyCharm docs after the major release.

@MichaReiser
Copy link
Member

Thank you

@MichaReiser MichaReiser merged commit d49c326 into astral-sh:main Nov 13, 2025
35 checks passed
dcreager added a commit that referenced this pull request Nov 14, 2025
* origin/main: (59 commits)
  [ty] Improve diagnostic range for `non-subscriptable` diagnostics (#21461)
  [ty] Improve literal promotion heuristics (#21439)
  [ty] Further improve details around which expressions should be deferred in stub files (#21456)
  [ty] Improve generic class constructor inference (#21442)
  [ty] Propagate type context through conditional expressions (#21443)
  [ty] Suppress completions when introducing names with `as`
  [ty] Add panic-by-default await methods to `TestServer` (#21451)
  [ty] name is parameter and global is a syntax error (#21312)
  [ty] Fixup a few details around version-specific dataclass features (#21453)
  [ty] Support attribute-expression `TYPE_CHECKING` conditionals (#21449)
  [ty] Support stringified annotations in value-position `Annotated` instances (#21447)
  [ty] Type inference for genererator expressions (#21437)
  [ty] Make `__getattr__` available for `ModuleType` instances (#21450)
  [ty] Increase default receive timeout in tests to 10s (#21448)
  [ty] Add synthetic members to completions on dataclasses (#21446)
  [ty] Support legacy `typing` special forms in implicit type aliases (#21433)
  Bump 0.14.5 (#21435)
  [ty] Support `type[…]` and `Type[…]` in implicit type aliases (#21421)
  [ty] Respect notebook cell boundaries when adding an auto import (#21322)
  Update PyCharm setup instructions (#21409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants