[ty] remove erroneous canonicalize

[Gankra]

Alternative implementation to #21052

[astral-sh-bot]

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

[astral-sh-bot]

mypy_primer results

Changes were detected when running on open source projects

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
- src/scikit_build_core/build/wheel.py:98:20: error[no-matching-overload] No overload of bound method `__init__` matches arguments
- Found 45 diagnostics
+ Found 44 diagnostics

Memory usage changes were detected when running on open source projects

flake8 (https://github.com/pycqa/flake8)
- TOTAL MEMORY USAGE: ~63MB
+ TOTAL MEMORY USAGE: ~66MB

[Gankra]

I'm claiming this is erroneous based on the fact that this canonicalize appears from seemingly nowhere in this commit:

ddd4bab

And removing it seems to fix the homebrew crasher without breaking anything else. I otherwise have no good intuition about it.

cc @BurntSushi

[Gankra]

(diagnostic change is the flake that's going around... memory usage change might be Why burntsushi made this change)

[MichaReiser]

Removing the canonicalize here looks correct to me. If it's needed for correctness (for whatever reason), than it should be moved here instead:

ruff/crates/ty_python_semantic/src/module_resolver/resolver.rs

Lines 289 to 292 in 376571e

	for path in site_packages_paths {
	tracing::debug!("Adding site-packages search path `{path}`");
	site_packages.push(SearchPath::site_packages(system, path.clone())?);
	}

But I'm inclined to just ship this as is

[Gankra]

Do we have any reasonable way to test this..?

[MichaReiser]

You could add a CLI test. We also have some file watching tests exercising symlinks.

ruff/crates/ty/tests/file_watching.rs

Line 1395 in 376571e

fn symlink_target_outside_watched_paths() -> anyhow::Result<()> {

[Gankra]

Awesome thank you micha!

That was frustratingly hard to get the right minimal conditions for the thing to reproduce in tests but I got it working, and this fix indeed fixes it.

[BurntSushi]

Thanks! I don't remember why I added this. I'm usually pretty skeptical of canonicalize.