Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions crates/ty/tests/cli/file_selection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,81 @@ fn explicit_path_overrides_exclude() -> anyhow::Result<()> {
Ok(())
}

#[test]
fn cli_and_configuration_exclude() -> anyhow::Result<()> {
let case = CliTest::with_files([
(
"src/main.py",
r#"
print(undefined_var) # error: unresolved-reference
"#,
),
(
"tests/generated.py",
r#"
print(dist_undefined_var) # error: unresolved-reference
"#,
),
(
"my_dist/other.py",
r#"
print(other_undefined_var) # error: unresolved-reference
"#,
),
(
"ty.toml",
r#"
[src]
exclude = ["tests/"]
"#,
),
])?;

assert_cmd_snapshot!(case.command(), @r"
success: false
exit_code: 1
----- stdout -----
error[unresolved-reference]: Name `other_undefined_var` used when not defined
--> my_dist/other.py:2:7
|
2 | print(other_undefined_var) # error: unresolved-reference
| ^^^^^^^^^^^^^^^^^^^
|
info: rule `unresolved-reference` is enabled by default

error[unresolved-reference]: Name `undefined_var` used when not defined
--> src/main.py:2:7
|
2 | print(undefined_var) # error: unresolved-reference
| ^^^^^^^^^^^^^
|
info: rule `unresolved-reference` is enabled by default

Found 2 diagnostics

----- stderr -----
");

assert_cmd_snapshot!(case.command().arg("--exclude").arg("my_dist/"), @r"
success: false
exit_code: 1
----- stdout -----
error[unresolved-reference]: Name `undefined_var` used when not defined
--> src/main.py:2:7
|
2 | print(undefined_var) # error: unresolved-reference
| ^^^^^^^^^^^^^
|
info: rule `unresolved-reference` is enabled by default

Found 1 diagnostic

----- stderr -----
");

Ok(())
}

#[test]
fn invalid_include_pattern() -> anyhow::Result<()> {
let case = CliTest::with_files([
Expand Down
10 changes: 10 additions & 0 deletions crates/ty_project/src/metadata/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1186,6 +1186,16 @@ impl From<OutputFormat> for DiagnosticFormat {
}
}

impl Combine for OutputFormat {
#[inline(always)]
fn combine_with(&mut self, _other: Self) {}

#[inline]
fn combine(self, _other: Self) -> Self {
self
}
}

#[derive(
Debug,
Default,
Expand Down
13 changes: 6 additions & 7 deletions crates/ty_project/src/metadata/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,13 @@ impl<T> RangedValue<T> {
}
}

impl<T> Combine for RangedValue<T> {
fn combine(self, _other: Self) -> Self
where
Self: Sized,
{
self
impl<T> Combine for RangedValue<T>
where
T: Combine,
{
fn combine_with(&mut self, other: Self) {
self.value.combine_with(other.value);
}
fn combine_with(&mut self, _other: Self) {}
}

impl<T> IntoIterator for RangedValue<T>
Expand Down
2 changes: 1 addition & 1 deletion crates/ty_python_semantic/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7488,7 +7488,7 @@ impl<'db> VarianceInferable<'db> for Type<'db> {
| Type::TypeAlias(_) => TypeVarVariance::Bivariant,
};

tracing::debug!(
tracing::trace!(
"Result of variance of '{tvar}' in `{ty:?}` is `{v:?}`",
tvar = typevar.typevar(db).name(db),
ty = self.display(db),
Expand Down
Loading