Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 20, 2025

This PR contains the following updates:

Package Type Update Change
ignore (source) workspace.dependencies patch 0.4.23 -> 0.4.24

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Fixes #21081


Release Notes

BurntSushi/ripgrep (ignore)

v0.4.24

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the internal An internal refactor or improvement label Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser
Copy link
Member

@BurntSushi any suggestions on what we should change on the ruff/ty side as part of this update? I see from the commits that there's a new global cwd option. Is this something we have to or should set now?

@BurntSushi
Copy link
Member

BurntSushi commented Oct 27, 2025

Yeah, the WalkBuilder::current_dir method lets you set the directory used for matching gitignore patterns from global gitignore exclusions or files added via WalkBuilder::add_ignore. If you don't set it, then it will automatically be pulled from std::env::current_dir for every use of WalkBuilder::build{_parallel}.

The main reasons to use WalkBuilder::current_dir explicitly are:

  1. You have a slightly different way of discovering the current working directory.
  2. You use many WalkBuilder::build{_parallel} calls but only want to query std::env::current_dir once.
  3. You don't want your libraries inspecting process global state for $reasons.

If those don't apply to ruff, then I think you can just leave it.

@MichaReiser
Copy link
Member

Thanks, that's helpful

  1. applies for both ty and ruff (although I consider this more a nice to have rather than being very performance critical)
    1 and 3: Apply for ty where we want to sue OsSystem::current_directory over std::env::current_dir (they should be the same but for consistency's sake)

@MichaReiser MichaReiser requested review from BurntSushi and removed request for carljm, dcreager and sharkdp October 28, 2025 17:38
@MichaReiser MichaReiser merged commit 4c4ddc8 into main Oct 28, 2025
40 checks passed
@MichaReiser MichaReiser deleted the renovate/ignore-0.x-lockfile branch October 28, 2025 17:49
dcreager added a commit that referenced this pull request Oct 28, 2025
…straint-sets

* dcreager/subtype-given-typevars:
  better comment
  restructure a bit
  better names/comments
  simplify before implication
  two typevars!
  [ty] Reformat constraint set mdtests (#21111)
  [ty] Move constraint set mdtest functions into `ConstraintSet` class (#21108)
  Avoid sending an unnecessary "clear diagnostics" message for clients supporting pull diagnostics (#21105)
  Update Rust crate ignore to v0.4.24 (#20979)
charliermarsh pushed a commit that referenced this pull request Nov 6, 2025
<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->
Since 4c4ddc8, ruff uses the `WalkBuilder::current_dir` API
[introduced in `ignore` version
0.4.24](https://diff.rs/ignore/0.4.23/0.4.24/src%2Fwalk.rs), so it
should explicitly depend on this minimum version.

See also #20979.

## Test Plan

<!-- How was it tested? -->
Source inspection verifies this version is necessary; no additional
testing is required since `Cargo.lock` already has (at least) this
version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruff format on multiple directories returns inconsistent results

3 participants