Update default and latest Python versions for 3.14 #20725

ntBre · 2025-10-06T16:31:11Z

Summary

Closes #19467 and also removes the warning about using Python 3.14 without
preview enabled.

I also bumped PythonVersion::default to 3.9 because it reaches EOL this month,
but we could also defer that for now if we wanted.

The first three commits are related to the latest bump to 3.14; the fourth commit
bumps the default to 3.10.

Note that this PR also bumps the default Python version for ty to 3.10 because
there was a test asserting that it stays in sync with ast::PythonVersion.

Test Plan

Existing tests

I spot-checked the ecosystem report, and I believe these are all expected. Inbits doesn't specify a target Python version, so I guess we're applying the default. UP007, UP035, and UP045 all use the new default value to emit new diagnostics.

Summary -- Closes #19467 and also removes the warning about using Python 3.14 without preview enabled. I also bumped `PythonVersion::default` to 3.9 because it reaches EOL this month, but we could also defer that for now if we wanted. I'm actually a bit concerned about some of the snapshot differences I saw. It looks like several rules that inspect annotations no longer work as expected, including FAST001, FAST003, A003, and PTH210. Possibly this is intentional, but it means that many, if not all, of these rules' diagnostics are eliminated. It looks like this might affect all of our `TypeChecker`-based rules, but I haven't looked too closely yet. I've just pinned all of the affected tests to use 3.13 for now, but we should follow up here if we don't have time to fix the underlying issue before the release. The test changes for 3.14 are in the second commit; reverting that seems like the best way to see all of the affected cases. Test Plan -- Existing tests

github-actions · 2025-10-06T16:33:35Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

github-actions · 2025-10-06T16:34:42Z

`mypy_primer` results

No ecosystem changes detected ✅
No memory usage changes detected ✅

github-actions · 2025-10-06T16:43:06Z

`ruff-ecosystem` results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+409 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

lnbits/lnbits (+409 -0 violations, +0 -0 fixes)

+ lnbits/app.py:281:26: UP045 [*] Use `X | None` for type annotations
+ lnbits/app.py:9:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/commands.py:158:42: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:215:11: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:216:12: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:217:13: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:218:14: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:306:43: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:357:16: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:358:21: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:359:17: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:360:18: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:361:10: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:362:17: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:447:17: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:448:18: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:449:10: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:450:17: UP045 [*] Use `X | None` for type annotations
... 374 additional changes omitted for rule UP045
+ lnbits/core/models/misc.py:3:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/core/tasks.py:4:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/core/views/auth_api.py:6:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/core/views/generic.py:164:42: UP007 [*] Use `X | Y` for type annotations
+ lnbits/decorators.py:140:36: UP007 [*] Use `X | Y` for type annotations
+ lnbits/decorators.py:141:36: UP007 [*] Use `X | Y` for type annotations
+ lnbits/decorators.py:142:36: UP007 [*] Use `X | Y` for type annotations
+ lnbits/lnurl.py:2:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/middleware.py:65:10: UP007 [*] Use `X | Y` for type annotations
+ lnbits/tasks.py:6:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/utils/crypto.py:43:29: UP007 [*] Use `X | Y` for type annotations
+ lnbits/utils/logger.py:6:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/utils/nostr.py:152:22: UP007 [*] Use `X | Y` for type annotations
+ lnbits/wallets/nwc.py:362:38: UP007 [*] Use `X | Y` for type annotations
+ lnbits/wallets/nwc.py:516:49: UP007 [*] Use `X | Y` for type annotations
+ tests/wallets/fixtures/models.py:27:15: UP007 [*] Use `X | Y` for type annotations
+ tests/wallets/test_rest_wallets.py:62:29: UP007 [*] Use `X | Y` for type annotations
+ tests/wallets/test_rest_wallets.py:84:22: UP007 [*] Use `X | Y` for type annotations
... 373 additional changes omitted for project

Changes by rule (3 rules affected)

code	total	+ violation
UP045	390	390
UP007	12	12
UP035	7	7

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+409 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

lnbits/lnbits (+409 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ lnbits/app.py:281:26: UP045 [*] Use `X | None` for type annotations
+ lnbits/app.py:9:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/commands.py:158:42: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:215:11: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:216:12: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:217:13: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:218:14: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:306:43: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:357:16: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:358:21: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:359:17: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:360:18: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:361:10: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:362:17: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:447:17: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:448:18: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:449:10: UP045 [*] Use `X | None` for type annotations
+ lnbits/commands.py:450:17: UP045 [*] Use `X | None` for type annotations
... 374 additional changes omitted for rule UP045
+ lnbits/core/models/misc.py:3:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/core/tasks.py:4:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/core/views/auth_api.py:6:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/core/views/generic.py:164:42: UP007 [*] Use `X | Y` for type annotations
+ lnbits/decorators.py:140:36: UP007 [*] Use `X | Y` for type annotations
+ lnbits/decorators.py:141:36: UP007 [*] Use `X | Y` for type annotations
+ lnbits/decorators.py:142:36: UP007 [*] Use `X | Y` for type annotations
+ lnbits/lnurl.py:2:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/middleware.py:65:10: UP007 [*] Use `X | Y` for type annotations
+ lnbits/tasks.py:6:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/utils/crypto.py:43:29: UP007 [*] Use `X | Y` for type annotations
+ lnbits/utils/logger.py:6:1: UP035 [*] Import from `collections.abc` instead: `Callable`
+ lnbits/utils/nostr.py:152:22: UP007 [*] Use `X | Y` for type annotations
+ lnbits/wallets/nwc.py:362:38: UP007 [*] Use `X | Y` for type annotations
+ lnbits/wallets/nwc.py:516:49: UP007 [*] Use `X | Y` for type annotations
+ tests/wallets/fixtures/models.py:27:15: UP007 [*] Use `X | Y` for type annotations
+ tests/wallets/test_rest_wallets.py:62:29: UP007 [*] Use `X | Y` for type annotations
+ tests/wallets/test_rest_wallets.py:84:22: UP007 [*] Use `X | Y` for type annotations
... 373 additional changes omitted for project

Changes by rule (3 rules affected)

code	total	+ violation
UP045	390	390
UP007	12	12
UP035	7	7

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

codspeed-hq · 2025-10-06T16:43:23Z

CodSpeed Performance Report

Merging #20725 will improve performances by 7.28%

_{Comparing brent/314 (e77312d) with main (8fb29ea)}

Summary

⚡ 2 improvements
✅ 49 untouched

Benchmarks breakdown

	Mode	Benchmark	`BASE`	`HEAD`	Change
⚡	Instrumentation	`linter/all-rules[pydantic/types.py]`	8.7 ms	8.1 ms	+7.28%
⚡	Instrumentation	`linter/all-with-preview-rules[pydantic/types.py]`	10.3 ms	9.7 ms	+6.15%

ntBre

I talked with @dylwil3 on Discord, and we think the removed diagnostics are related to pre-existing issues. He tested at least some of them and found that the diagnostics are also suppressed on earlier Python versions with from __future__ import annotations, so I'm planning to open a follow-up issue and not block the release, if that sounds good to everyone. The rules that look suspicious to me (and I'll include in the follow-up issue) are:

FAST001
FAST003
A003
PTH210
RUF001

In general, these look like cases where we no longer visit annotations because they aren't evaluated at runtime, but it seems like a worse result not to visit these annotations since it prevents us from emitting helpful diagnostics.

On the other side, the rules with changes that look correct to me are:

PYI055
TC001-TC004
F821
UP037
UP006
UP007
UP036
RUF058

Somewhere in between I'd put TC010. String union members are allowed on 3.14, but we probably still want to emit some diagnostic for "int" | str; this doesn't seem to trigger any of the TC rules unless I'm missing some additional configuration.

One remaining question is whether it's better to accept these snapshots or pin them to 3.13. I think it's probably easier to pin for now and then remove the pins while addressing the follow-up issue, but I'm curious what others think.

ntBre · 2025-10-06T17:27:32Z

.../src/rules/flake8_pyi/snapshots/ruff_linter__rules__flake8_pyi__tests__PYI055_PYI055.py.snap

+  |
+2 | from typing import Union
+3 |
+4 | s: builtins.type[int] | builtins.type[str] | builtins.type[complex]


I think these are correct. The check disabling these on earlier Python versions was added in #6457:

ruff/crates/ruff_linter/src/rules/flake8_pyi/rules/unnecessary_type_union.rs

Lines 64 to 67 in 70f51e9

// The `|` operator isn't always safe to allow to runtime-evaluated annotations.

if semantic.execution_context().is_runtime() {

return;

}

sharkdp

The ty changes look good to me, thank you!

@AlexWaygood Are there any interactions with typeshed here that we should worry about? Going to a higher default version should be fine, I think?

sharkdp · 2025-10-07T07:09:58Z

crates/ty_python_semantic/src/types/class.rs

            .set_python_version_with_source(&mut db)
            .to(PythonVersionWithSource {
-                version: PythonVersion::latest_preview(),
+                version: PythonVersion::latest(),


Is the change here necessary? It seems to me like we would want to run this test on 3.15 preview soon?

AlexWaygood · 2025-10-07T09:44:59Z

@AlexWaygood Are there any interactions with typeshed here that we should worry about? Going to a higher default version should be fine, I think?

Yes, should be fine!

AlexWaygood · 2025-10-07T09:51:08Z

crates/ty/src/python_version.rs

should we not add a Py314 variant to the PythonVersion enum in this file? We should definitely let ty users specify --python-version=3.14!

MichaReiser · 2025-10-07T10:14:00Z

I agree that we shouldn't block the release if those are pre-existing issues, and creating follow-up issues sounds great. I do think that it's somewhat important to look into what's happening. From a quick investigation, it seems that

return dbg!(semantic.resolve_name(response_mode_name_expr))
            == dbg!(semantic.resolve_name(return_value_name_expr));

now returns false because resolve_name for the return value returns None. I haven't investigated further. @dylwil3 is this something you could take a look at. Unless @ntBre want's to fix it before the release ;)

Regarding the tests. For tests that regress, I'd prefer to use test_path_with_settings_diff so that it clearly demonstrates the undesired difference. The bugfix PR should then remove all the diffs.

The stringified union example is a bit funny (but also pre-existing).

x: "int" | str

is reported by TC010 but the following isn't, because the rule isn't in a runtime context:

from __future__ import annotations

x: "int" | str

I'd say this is also a pre-existing issue that doesn't need to block the 3.14 release

MichaReiser · 2025-10-07T09:57:24Z

crates/ty/src/python_version.rs

-    #[default]
    #[value(name = "3.9")]
    Py39,
+    #[default]


We also need to update the default value in the ruff settings documentation here

MichaReiser · 2025-10-07T09:58:39Z

crates/ruff_python_parser/tests/fixtures.rs

    let source = fs::read_to_string(input_path).expect("Expected test file to exist");
    let options = extract_options(&source).unwrap_or_else(|| {
-        ParseOptions::from(Mode::Module).with_target_version(PythonVersion::latest_preview())
+        ParseOptions::from(Mode::Module).with_target_version(PythonVersion::latest())


I think it makes sense to keep latest_preview and use it here as we, very intentionally, want to use the latest preview version for parser tests.

ntBre · 2025-10-07T15:16:09Z

Thanks all for the reviews!

I think I've addressed all the feedback and will draft the follow-up issue while CI runs.

ntBre added 4 commits October 6, 2025 10:52

pin changed tests to 3.13

1c5b862

revert version pin, accept snapshots instead

095acaf

update default version from 3.9 to 3.10

ffa4635

ntBre added breaking Breaking API change python314 Related to Python 3.14 labels Oct 6, 2025

ntBre commented Oct 6, 2025

View reviewed changes

ntBre added this to the v0.14 milestone Oct 6, 2025

ntBre marked this pull request as ready for review October 6, 2025 18:16

ntBre requested review from AlexWaygood, MichaReiser, carljm, dcreager, dhruvmanila and sharkdp as code owners October 6, 2025 18:16

ntBre removed request for carljm, dcreager, dhruvmanila and sharkdp October 6, 2025 18:16

sharkdp approved these changes Oct 7, 2025

View reviewed changes

AlexWaygood reviewed Oct 7, 2025

View reviewed changes

MichaReiser approved these changes Oct 7, 2025

View reviewed changes

ntBre added 2 commits October 7, 2025 09:25

update target-version docs

3d3e3b5

restore latest_preview and its uses

5331810

ntBre added 8 commits October 7, 2025 09:28

add 3.14 to ty's PythonVersion

b25ec75

Merge branch 'main' into brent/314

13e935d

fixup! update target-version docs

6279358

update more moved tests

07cd34a

fixup! add 3.14 to ty's PythonVersion

f8fe264

allow optional trailing comma in assert_diagnostics_diff

fd9fdbe

add assert_diagnostics_diff branch without a snapshot argument

8c1bd06

add assert_diagnostics_diff tests for changed rules

a658f41

ntBre mentioned this pull request Oct 7, 2025

Fix several rules to handle deferred annotations #20747

Open

fix some test comments

e77312d

ntBre merged commit 88c0ce3 into main Oct 7, 2025
39 checks passed

ntBre deleted the brent/314 branch October 7, 2025 16:23

BrewTestBot mentioned this pull request Oct 7, 2025

ruff 0.14.0 Homebrew/homebrew-core#247299

Merged

	// The `\|` operator isn't always safe to allow to runtime-evaluated annotations.
	if semantic.execution_context().is_runtime() {
	return;
	}

Update default and latest Python versions for 3.14 #20725

Update default and latest Python versions for 3.14 #20725

Uh oh!

Conversation

ntBre commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

codspeed-hq bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #20725 will improve performances by 7.28%

Summary

Benchmarks breakdown

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

ntBre Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

sharkdp left a comment

Choose a reason for hiding this comment

Uh oh!

sharkdp Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

AlexWaygood commented Oct 7, 2025

Uh oh!

AlexWaygood Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaReiser commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaReiser Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

ntBre commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ntBre commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading

`mypy_primer` results

github-actions bot commented Oct 6, 2025 •

edited

Loading

`ruff-ecosystem` results

codspeed-hq bot commented Oct 6, 2025 •

edited

Loading

AlexWaygood Oct 7, 2025 •

edited

Loading

MichaReiser commented Oct 7, 2025 •

edited

Loading