Skip to content

[ty] [testing impact of proposed typeshed change]#19969

Closed
AlexWaygood wants to merge 1 commit intomainfrom
typeshed-experiment
Closed

[ty] [testing impact of proposed typeshed change]#19969
AlexWaygood wants to merge 1 commit intomainfrom
typeshed-experiment

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Aug 18, 2025

Testing the impact for us if python/typeshed#14583 were merged upstream

@AlexWaygood AlexWaygood added do-not-merge Do not merge this pull request ty Multi-file analysis & type inference labels Aug 18, 2025
@github-actions
Copy link
Contributor

Diagnostic diff on typing conformance tests

Changes were detected when running ty on typing conformance tests
--- old-output.txt	2025-08-18 13:51:17.962702396 +0000
+++ new-output.txt	2025-08-18 13:51:20.444706451 +0000
@@ -1,5 +1,5 @@
 WARN ty is pre-release software and not ready for production use. Expect to encounter bugs, missing features, and fatal errors.
-fatal[panic] Panicked at /home/runner/.cargo/git/checkouts/salsa-e6f3bb7c2a062968/918d35d/src/function/execute.rs:215:25 when checking `/home/runner/work/ruff/ruff/typing/conformance/tests/aliases_typealiastype.py`: `infer_definition_types(Id(9637)): execute: too many cycle iterations`
+fatal[panic] Panicked at /home/runner/.cargo/git/checkouts/salsa-e6f3bb7c2a062968/918d35d/src/function/execute.rs:215:25 when checking `/home/runner/work/ruff/ruff/typing/conformance/tests/aliases_typealiastype.py`: `infer_definition_types(Id(9640)): execute: too many cycle iterations`
 _directives_deprecated_library.py:15:31: error[invalid-return-type] Function always implicitly returns `None`, which is not assignable to return type `int`
 _directives_deprecated_library.py:30:26: error[invalid-return-type] Function always implicitly returns `None`, which is not assignable to return type `str`
 _directives_deprecated_library.py:36:41: error[invalid-return-type] Function always implicitly returns `None`, which is not assignable to return type `Self@__add__`

@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed Instrumentation Performance Report

Merging #19969 will degrade performances by 5.3%

Comparing typeshed-experiment (cf51684) with main (e4f1b58)

Summary

❌ 1 regressions
✅ 41 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
ty_micro[many_string_assignments] 68.3 ms 72.1 ms -5.3%

@AlexWaygood AlexWaygood deleted the typeshed-experiment branch August 21, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this pull request ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant