Skip to content

[ty] Remove unsafe salsa::Update implementations in tuple.rs #19880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

[ty] Remove unsafe salsa::Update implementations in tuple.rs #19880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions crates/ty_python_semantic/src/types/tuple.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,19 +452,6 @@ impl<'db> FixedLengthTuple<Type<'db>> {
}
}

#[allow(unsafe_code)]
unsafe impl<T> salsa::Update for FixedLengthTuple<T>
where
T: salsa::Update,
{
unsafe fn maybe_update(old_pointer: *mut Self, new_value: Self) -> bool {
unsafe {
let old_value = &mut *old_pointer;
Box::maybe_update(&raw mut old_value.0, new_value.0)
}
}
}

impl<'db> PyIndex<'db> for &FixedLengthTuple<Type<'db>> {
type Item = Type<'db>;

Expand Down Expand Up @@ -847,21 +834,6 @@ impl<'db> VariableLengthTuple<Type<'db>> {
}
}

#[allow(unsafe_code)]
unsafe impl<T> salsa::Update for VariableLengthTuple<T>
where
T: salsa::Update,
{
unsafe fn maybe_update(old_pointer: *mut Self, new_value: Self) -> bool {
let old_value = unsafe { &mut *old_pointer };
let mut changed = false;
changed |= unsafe { Box::maybe_update(&raw mut old_value.prefix, new_value.prefix) };
changed |= unsafe { T::maybe_update(&raw mut old_value.variable, new_value.variable) };
changed |= unsafe { Box::maybe_update(&raw mut old_value.suffix, new_value.suffix) };
changed
}
}

impl<'db> PyIndex<'db> for &VariableLengthTuple<Type<'db>> {
type Item = Type<'db>;

Expand Down Expand Up @@ -1149,28 +1121,6 @@ impl<T> From<VariableLengthTuple<T>> for Tuple<T> {
}
}

#[allow(unsafe_code)]
unsafe impl<T> salsa::Update for Tuple<T>
where
T: salsa::Update,
{
unsafe fn maybe_update(old_pointer: *mut Self, new_value: Self) -> bool {
let old_value = unsafe { &mut *old_pointer };
match (old_value, new_value) {
(Tuple::Fixed(old), Tuple::Fixed(new)) => unsafe {
FixedLengthTuple::maybe_update(old, new)
},
(Tuple::Variable(old), Tuple::Variable(new)) => unsafe {
VariableLengthTuple::maybe_update(old, new)
},
(old_value, new_value) => {
*old_value = new_value;
true
}
}
}
}

impl<'db> PyIndex<'db> for &Tuple<Type<'db>> {
type Item = Type<'db>;

Expand Down
Loading