-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] Avoid overcounting shared memory usage #19773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
|
f72569d to
898c4c3
Compare
MichaReiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth considering to vendor our own get_size (in ruff memory usage). It's not very complicated code.
salsa-rs/salsa#944 would allow us to avoid the global lock.
d8cc48f to
f279122
Compare
f279122 to
aa1c34a
Compare
aa1c34a to
ee45cc6
Compare
|
It looks like |
Summary
Use a global tracker to avoid double counting
Arcinstances.