[ty] Link directly to typing conformance test suite when commenting the diff #19736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small quality-of-life improvement to make it easier to evaluate whether a typing-conformance diff is good or bad
AlexWaygood
added
ci
AlexWaygood
changed the title
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
dhruvmanila
approved these changes
Aug 4, 2025
| echo '<!-- generated-comment typing_conformance_diagnostics_diff -->' >> comment.txt | ||
| echo '## Diagnostic diff on typing conformance tests' >> comment.txt | ||
| echo "## Diagnostic diff on [typing conformance tests](https://github.com/python/typing/tree/${CONFORMANCE_SUITE_COMMIT}/conformance)" >> comment.txt |
Member
There was a problem hiding this comment.
nit: it might be worth linking directly to the conformance/tests directory?
Member
Author
There was a problem hiding this comment.
I considered it, but I like that this directory has a README.md file (which might be useful for first-time contributors!), whereas the tests subdirectory doesn't :-)
Member
Author
|
Ugh, it appears to be uploading the commit correctly: https://github.com/astral-sh/ruff/actions/runs/16730858154?pr=19669 And I think it is downloading it correctly: https://github.com/astral-sh/ruff/actions/runs/16730894339/job/47358456147 but the links are not making it into the comment correctly, for whatever reason: #19669 (comment) |
dhruvmanila
added a commit
that referenced
this pull request
Aug 5, 2025
## Summary This PR fixes the issue mentioned in #19736 (comment) ~~but I can't test it without merging it on `main` because GitHub Actions still pickup the old version of the workflow file.~~ and is tested by manually triggering the workflow, refer to the comment on this PR (#19754 (comment)) which has the commit hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small quality-of-life improvement to make it easier to evaluate whether a typing-conformance diff is good or bad
Test Plan