Skip to content

[ty] Refactor TypeInferenceBuilder::infer_subscript_expression_types #19658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

[ty] Refactor TypeInferenceBuilder::infer_subscript_expression_types #19658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b17d74
[ty] Refactor `TypeInferenceBuilder::infer_subscript_expression_types`
AlexWaygood Jul 31, 2025
f4d5c54
rework `match` to return an `Option`
AlexWaygood Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/ty_python_semantic/src/types/class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4213,14 +4213,14 @@ pub(crate) struct SliceLiteral {
pub(crate) step: Option<i32>,
}

impl<'db> Type<'db> {
/// If this type represents a valid slice literal, returns a [`SliceLiteral`] describing it.
impl<'db> ClassType<'db> {
/// If this class is a specialization of `slice`, returns a [`SliceLiteral`] describing it.
/// Otherwise returns `None`.
///
/// The type must be a specialization of the `slice` builtin type, where the specialized
/// typevars are statically known integers or `None`.
/// The specialization must be one in which the typevars are solved as being statically known
/// integers or `None`.
pub(crate) fn slice_literal(self, db: &'db dyn Db) -> Option<SliceLiteral> {
let ClassType::Generic(alias) = self.into_nominal_instance()?.class else {
let ClassType::Generic(alias) = self else {
return None;
};
if !alias.origin(db).is_known(db, KnownClass::Slice) {
Expand Down
Loading
Loading