[ty] Find legacy typevars using a TypeVisitor
#19625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcreager
commented
Jul 29, 2025
Comment on lines
340
to
349
| visit_type(db, ty, |_, ty| { | ||
| if found_matching_type { | ||
| return Err(AbortTypeVisitor); | ||
| } | ||
| found_matching_type |= query(ty); | ||
| if found_matching_type { | ||
| return Err(AbortTypeVisitor); | ||
| } | ||
| Ok(()) | ||
| }); |
There was a problem hiding this comment.
Here is what it looks like to use the new recursion guard helper with a closure that automatically implements the TypeVisitor trait.
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
CodSpeed Instrumentation Performance ReportMerging #19625 will degrade performances by 35.67%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #19625 will degrade performances by 4.39%Comparing Summary
Benchmarks breakdown
|
|
This should be a no-op; moving to draft while I investigate the ecosystem changes |
|
Superseded by #20124 |
|
I forgot about this PR -- it does some nice things that my PR didn't, that would be great to revisit someday. But apparently it also changed semantics, which mine didn't 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a nice mechanism for visiting a type, we can replace the
find_legacy_typevarsmethod with aTypeVisitor. To make this happen, this PR also adds the following:AbortTypeVisitorresult to end the visitor early.TypeVisitorfor closures that have the right signature, meaning that we usually won't need to create a named type for the visitor.