Skip to content

Conversation

@dhruvmanila
Copy link
Member

Summary

This PR updates the ResolvedClientCapabilities to be represented as bitflags. This allows us to remove the Arc as the type becomes copy.

Additionally, this PR also fixed the goto definition and declaration code to use the textDocument.definition.linkSupport and textDocument.declaration.linkSupport client capability.

This PR also removes the unused client capabilities which are code_action_deferred_edit_resolution, apply_edit, and document_changes which are all related to auto-fix ability.

@dhruvmanila dhruvmanila requested a review from carljm as a code owner July 17, 2025 08:33
@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jul 17, 2025
@dhruvmanila dhruvmanila added the server Related to the LSP server label Jul 17, 2025
@dhruvmanila dhruvmanila requested a review from dcreager as a code owner July 17, 2025 08:33
@dhruvmanila dhruvmanila added the ty Multi-file analysis & type inference label Jul 17, 2025
@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to parse examples/mcp/databricks_mcp_cookbook.ipynb:12:1:8: Simple statements must be separated by newlines or semicolons

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to parse examples/mcp/databricks_mcp_cookbook.ipynb:12:1:8: Simple statements must be separated by newlines or semicolons

@dhruvmanila dhruvmanila merged commit c2a05b4 into main Jul 17, 2025
39 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/bitflags-for-resolved-client-capabilities branch July 17, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement server Related to the LSP server ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants