Skip to content

[ty] Rewrite Type::any_over_type using a new generalised TypeVisitor trait #19094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

[ty] Rewrite Type::any_over_type using a new generalised TypeVisitor trait #19094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aa2fe0
[ty] Rewrite `Type::any_over_type` using a new generalised `TypeVisit…
AlexWaygood Jul 2, 2025
737afeb
rename other `TypeVisitor`, fix walking of PEP-695 aliases
AlexWaygood Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/ty_python_semantic/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ pub mod pull_types;

type FxOrderSet<V> = ordermap::set::OrderSet<V, BuildHasherDefault<FxHasher>>;
type FxIndexMap<K, V> = indexmap::IndexMap<K, V, BuildHasherDefault<FxHasher>>;
type FxIndexSet<V> = indexmap::IndexSet<V, BuildHasherDefault<FxHasher>>;
Copy link
Contributor

@carljm carljm Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if some of our existing uses of FxOrderSet should actually be FxIndexSet, if we don't need the stronger equality and order-maintenance guarantees provided by the ordermap wrapper crate? Not something for this PR, though.

Copy link
Member Author

@AlexWaygood AlexWaygood Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think an FxIndexSet is hashable, so I think we do need to use FxOrderSet for the fields on IntersectionType, for example. But yeah, it does look like a bunch of places are using an OrderSet right now when they probably only really need an IndexSet.


/// Returns the default registry with all known semantic lints.
pub fn default_lint_registry() -> &'static LintRegistry {
Expand Down
Loading
Loading