[refurb] Fix false positive on empty tuples (FURB168)
#19058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #19047 / the isinstance-type-none (FURB168) tuple false positive by adding a check if the tuple is empty to the code. I also noticed there was another false positive with the other tuple check in the same function, so I fixed it the same way.
Union[()]is invalid at runtime withTypeError: Cannot take a Union of no types., but it is accepted bybasedpyrightplayground and is equivalent toNever, so I fixed it anyways. I'm getting on a side tangent here, but it looks like MyPy doesn't accept it, and ty playground gives@Todo.Test Plan
Added two test cases for the two false positives. playground