Document link between import-outside-top-level (PLC0415) and lint.flake8-tidy-imports.banned-module-level-imports
#18733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8-tidy-imports_banned-module-level-imports
Avasam
force-pushed
the
document-link-between-import-outside-top-level-PLC0415-and-lint_flake8-tidy-imports_banned-module-level-imports
branch
from
34f0033 to
d194c49
Compare
Avasam
commented
Jun 17, 2025
crates/ruff_linter/src/rules/pylint/rules/import_outside_top_level.rs
Outdated
Show resolved
Hide resolved
Avasam
commented
Jun 17, 2025
Avasam
changed the title
import-outside-top-level (PLC0415) and lint.flake8-tidy-imports.banned-module-level-imports
Contributor
|
ntBre
approved these changes
Jun 18, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you! This looks great. We might just need to clarify that TID253 has to be enabled. Good idea to check that!
crates/ruff_linter/src/rules/pylint/rules/import_outside_top_level.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review! I'm away for the weekend, I'll complete this next week. (It's not urgent anyway) |
Avasam
deleted the
document-link-between-import-outside-top-level-PLC0415-and-lint_flake8-tidy-imports_banned-module-level-imports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #18728 (comment) CC @ntBre
Test Plan
Run the docs locally as per https://github.com/astral-sh/ruff/blob/a2cd6df429a3e76880a48a5eb8816a86c36927ed/CONTRIBUTING.md#mkdocs