Skip to content

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Jun 5, 2025

Summary

  • mark unused-unpacked-variable (RUF059) as stable in the rule registry

@ntBre
Copy link
Contributor Author

ntBre commented Jun 5, 2025

It nailed this one, the test cases are already on rules not preview_rules, and there are no additional preview checks in the rule code itself.

@ntBre ntBre changed the base branch from main to brent/release-0.12.0 June 5, 2025 16:38
@ntBre ntBre force-pushed the brent/release-0.12.0 branch from da71e0a to 5f1af44 Compare June 5, 2025 16:39
@ntBre ntBre changed the title Stabilize RUF059 [ruff] Stabilize RUF059 Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+846 -2 violations, +0 -0 fixes in 21 projects; 34 projects unchanged)

RasaHQ/rasa (+39 -0 violations, +0 -0 fixes)

+ rasa/telemetry.py:594:30: RUF059 Unpacked variable `tb` is never used
+ rasa/telemetry.py:594:9: RUF059 Unpacked variable `exc_type` is never used
+ tests/cli/test_rasa_export.py:278:5: RUF059 Unpacked variable `events` is never used
+ tests/core/evaluation/test_marker.py:287:13: RUF059 Unpacked variable `expected` is never used
+ tests/core/evaluation/test_marker.py:307:13: RUF059 Unpacked variable `expected` is never used
+ tests/core/evaluation/test_marker.py:558:13: RUF059 Unpacked variable `expected_size` is never used
+ tests/core/evaluation/test_marker.py:583:13: RUF059 Unpacked variable `expected_size` is never used
+ tests/core/test_evaluation.py:152:23: RUF059 Unpacked variable `num_stories` is never used
+ tests/core/test_evaluation.py:319:23: RUF059 Unpacked variable `num_stories` is never used
+ tests/core/training/test_interactive.py:818:11: RUF059 Unpacked variable `kwargs` is never used
... 29 additional changes omitted for project

apache/airflow (+86 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ airflow-core/src/airflow/api_fastapi/execution_api/deps.py:140:21: RUF059 Unpacked variable `exc` is never used
+ airflow-core/src/airflow/configuration.py:1654:22: RUF059 Unpacked variable `source` is never used
+ airflow-core/src/airflow/configuration.py:723:25: RUF059 Unpacked variable `should_continue` is never used
+ airflow-core/src/airflow/executors/local_executor.py:217:25: RUF059 Unpacked variable `exc` is never used
+ airflow-core/src/airflow/providers_manager.py:929:13: RUF059 Unpacked variable `module` is never used
+ airflow-core/src/airflow/providers_manager.py:929:21: RUF059 Unpacked variable `class_name` is never used
+ airflow-core/src/airflow/ti_deps/deps/ready_to_reschedule.py:49:9: RUF059 Unpacked variable `executor` is never used
+ airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py:639:17: RUF059 Unpacked variable `asset2` is never used
+ airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py:639:9: RUF059 Unpacked variable `asset1` is never used
+ airflow-core/tests/unit/cli/commands/_common_cli_classes.py:156:9: RUF059 Unpacked variable `gone` is never used
... 76 additional changes omitted for project

apache/superset (+13 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ scripts/check-env.py:67:24: RUF059 Unpacked variable `supported_max` is never used
+ superset/commands/report/alert.py:172:13: RUF059 Unpacked variable `executor` is never used
+ tests/integration_tests/core_tests.py:299:21: RUF059 Unpacked variable `tests` is never used
+ tests/integration_tests/dict_import_export_tests.py:168:9: RUF059 Unpacked variable `table` is never used
+ tests/integration_tests/dict_import_export_tests.py:173:9: RUF059 Unpacked variable `table_over` is never used
+ tests/integration_tests/dict_import_export_tests.py:197:9: RUF059 Unpacked variable `table` is never used
... 6 additional changes omitted for rule RUF059
+ tests/integration_tests/utils_tests.py:379:9: ANN201 Missing return type annotation for public function `test_schema_one_of_case_insensitive`
- tests/integration_tests/utils_tests.py:379:9: ANN201 Missing return type annotation for public function `test_schema_one_of_case_insensitive`
+ tests/unit_tests/db_engine_specs/test_mysql.py:215:5: D212 [*] Multi-line docstring summary should start at the first line
- tests/unit_tests/db_engine_specs/test_mysql.py:215:5: D212 [*] Multi-line docstring summary should start at the first line
... 5 additional changes omitted for project

binary-husky/gpt_academic (+52 -0 violations, +0 -0 fixes)

+ crazy_functions/Conversation_To_File.py:223:9: RUF059 Unpacked variable `html` is never used
+ crazy_functions/Latex_Function.py:382:18: RUF059 Unpacked variable `downloaded` is never used
+ crazy_functions/Social_Helper.py:70:17: RUF059 Unpacked variable `err_msg` is never used
+ crazy_functions/agent_fns/python_comment_agent.py:216:9: RUF059 Unpacked variable `begin` is never used
+ crazy_functions/crazy_utils.py:122:21: RUF059 Unpacked variable `p_ratio` is never used
+ crazy_functions/crazy_utils.py:269:21: RUF059 Unpacked variable `p_ratio` is never used
+ crazy_functions/crazy_utils.py:606:13: RUF059 Unpacked variable `stdout` is never used
+ crazy_functions/crazy_utils.py:606:21: RUF059 Unpacked variable `stderr` is never used
+ crazy_functions/game_fns/game_interactive_story.py:97:13: RUF059 Unpacked variable `image_url` is never used
+ crazy_functions/latex_fns/latex_toolbox.py:605:17: RUF059 Unpacked variable `stderr` is never used
... 42 additional changes omitted for project

bokeh/bokeh (+25 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ src/bokeh/sphinxext/bokeh_model.py:121:34: RUF059 Unpacked variable `arglist` is never used
+ src/bokeh/sphinxext/bokeh_model.py:121:43: RUF059 Unpacked variable `retann` is never used
+ src/bokeh/sphinxext/bokeh_model.py:121:9: RUF059 Unpacked variable `name_prefix` is never used
+ src/bokeh/sphinxext/bokeh_options.py:108:36: RUF059 Unpacked variable `arglist` is never used
+ src/bokeh/sphinxext/bokeh_options.py:108:45: RUF059 Unpacked variable `retann` is never used
+ src/bokeh/sphinxext/bokeh_options.py:108:9: RUF059 Unpacked variable `name_prefix` is never used
+ src/bokeh/sphinxext/bokeh_plot.py:254:15: RUF059 Unpacked variable `lineno` is never used
+ src/bokeh/sphinxext/bokeh_settings.py:84:32: RUF059 Unpacked variable `arglist` is never used
+ src/bokeh/sphinxext/bokeh_settings.py:84:41: RUF059 Unpacked variable `retann` is never used
+ src/bokeh/sphinxext/bokeh_settings.py:84:9: RUF059 Unpacked variable `name_prefix` is never used
... 15 additional changes omitted for project

ibis-project/ibis (+2 -0 violations, +0 -0 fixes)

+ ibis/backends/tests/test_set_ops.py:40:12: RUF059 Unpacked variable `c` is never used
+ ibis/backends/tests/test_set_ops.py:40:25: RUF059 Unpacked variable `dc` is never used

latchbio/latch (+2 -0 violations, +0 -0 fixes)

+ src/latch_cli/services/test_data/remove.py:23:44: RUF059 Unpacked variable `account_id` is never used
+ src/latch_cli/snakemake/workflow.py:295:9: RUF059 Unpacked variable `val` is never used

lnbits/lnbits (+1 -0 violations, +0 -0 fixes)

+ tests/api/test_api.py:317:5: RUF059 Unpacked variable `fake_data` is never used

milvus-io/pymilvus (+1 -0 violations, +0 -0 fixes)

+ examples/orm/collection.py:139:5: RUF059 Unpacked variable `raw_vectors` is never used

pandas-dev/pandas (+84 -0 violations, +0 -0 fixes)

+ doc/make.py:81:9: RUF059 Unpacked variable `base_name` is never used
+ doc/source/conf.py:621:18: RUF059 Unpacked variable `parent` is never used
+ doc/source/conf.py:621:26: RUF059 Unpacked variable `modname` is never used
+ pandas/core/_numba/kernels/mean_.py:174:23: RUF059 Unpacked variable `comp_arr` is never used
+ pandas/core/_numba/kernels/sum_.py:235:23: RUF059 Unpacked variable `comp_arr` is never used
+ pandas/core/apply.py:1097:19: RUF059 Unpacked variable `kwargs` is never used
+ pandas/core/apply.py:1266:15: RUF059 Unpacked variable `kwargs` is never used
+ pandas/core/apply.py:1408:15: RUF059 Unpacked variable `kwargs` is never used
+ pandas/core/arrays/datetimelike.py:1097:19: RUF059 Unpacked variable `o_mask` is never used
+ pandas/core/arrays/datetimelike.py:1160:19: RUF059 Unpacked variable `o_mask` is never used
... 74 additional changes omitted for project

pypa/build (+3 -0 violations, +0 -0 fixes)

+ tests/test_main.py:126:10: RUF059 Unpacked variable `err` is never used
+ tests/test_main.py:314:13: RUF059 Unpacked variable `stderr` is never used
+ tests/test_projectbuilder.py:419:10: RUF059 Unpacked variable `err` is never used

pypa/cibuildwheel (+3 -0 violations, +0 -0 fixes)

+ test/test_ios.py:322:5: RUF059 Unpacked variable `out` is never used
+ test/test_ios.py:346:5: RUF059 Unpacked variable `out` is never used
+ test/test_pyodide.py:100:5: RUF059 Unpacked variable `out` is never used

python-poetry/poetry (+4 -0 violations, +0 -0 fixes)

+ src/poetry/repositories/link_sources/base.py:80:19: RUF059 Unpacked variable `ext` is never used
+ src/poetry/utils/helpers.py:258:10: RUF059 Unpacked variable `type` is never used
+ tests/console/test_application.py:126:10: RUF059 Unpacked variable `name` is never used
+ tests/console/test_application.py:126:16: RUF059 Unpacked variable `args` is never used

reflex-dev/reflex (+3 -0 violations, +0 -0 fixes)

+ reflex/compiler/compiler.py:870:20: RUF059 Unpacked variable `enable_state` is never used
+ reflex/istate/manager.py:356:23: RUF059 Unpacked variable `substate` is never used
+ reflex/istate/manager.py:371:23: RUF059 Unpacked variable `substate` is never used

scikit-build/scikit-build (+3 -0 violations, +0 -0 fixes)

+ tests/test_command_line.py:28:10: RUF059 Unpacked variable `err` is never used
+ tests/test_command_line.py:36:10: RUF059 Unpacked variable `err` is never used
+ tests/test_command_line.py:45:10: RUF059 Unpacked variable `err` is never used

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (3 rules affected)

code total + violation - violation + fix - fix
RUF059 844 844 0 0 0
ANN201 2 1 1 0 0
D212 2 1 1 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added the rule Implementing or modifying a lint rule label Jun 5, 2025
@ntBre ntBre added this to the v0.12 milestone Jun 5, 2025
@ntBre ntBre marked this pull request as draft June 5, 2025 16:41
@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 5f1af44 to 11966be Compare June 6, 2025 14:14
@ntBre
Copy link
Contributor Author

ntBre commented Jun 6, 2025

#18507

@ntBre ntBre closed this Jun 6, 2025
@ntBre ntBre mentioned this pull request Jun 6, 2025
2 tasks
@shearer12345
Copy link

@ntBre Stabilizing RUF059 was marked deferred in #18427 for 0.12.0 (I believe because of #18507 )

Do you intend for it to stabilize for 0.13.0? I'm not sure from https://docs.astral.sh/ruff/versioning/#rule-stabilization and when #18507 came in if RUF059 is eligible for 0.13.0 or not.

Would that come in with this PR? or would you need a fresh one?

@ntBre
Copy link
Contributor Author

ntBre commented Sep 3, 2025

Yep, I think your assessment is correct. We're collecting the stabilization candidates for 0.13 this week, and RUF059 is on the list. We could probably use a fresh PR rather than resurrecting this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants