Skip to content

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented May 19, 2025

Summary

See comment here: #18156 (comment)

@sharkdp sharkdp added internal An internal refactor or improvement ty Multi-file analysis & type inference labels May 19, 2025
Copy link
Member

@dcreager dcreager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅

Comment on lines +1 to +3
rules.md -diff linguist-generated=true text=auto eol=lf
cli.md -diff linguist-generated=true text=auto eol=lf
configuration.md -diff linguist-generated=true text=auto eol=lf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sometimes nice to see how these files render but I guess it's not preventing me from doing just that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if they are completely hidden or if there is still a way to get to the diff. I guess we can revert this if we'd rather see them anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can still see the diff, you just need to click a "show diff for this generated file" button in the "Files changed" tab

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And on the command line you can add -a to any git diff command

@sharkdp sharkdp merged commit b913f56 into main May 19, 2025
35 checks passed
@sharkdp sharkdp deleted the david/generated-files branch May 19, 2025 14:50
dcreager added a commit that referenced this pull request May 19, 2025
* main:
  [ty] Infer function call typevars in both directions (#18155)
  Add rustfmt.toml file (#18197)
  [ty] Update mypy primer (#18196)
  [ty] Mark generated files as such in .gitattributes (#18195)
  [ty] Support `typing.TypeAliasType` (#18156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants