Update MSRV to 1.85 and toolchain to 1.87 #18126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
commented
May 16, 2025
| enum SourceTextKind { | ||
| Text(String), | ||
| Notebook(Notebook), | ||
| Notebook(Box<Notebook>), |
Member
Author
There was a problem hiding this comment.
Notebooks are massive and clippy complaint that the enum variants where significantly different in size (24 vs > 500)
Contributor
|
Contributor
|
sharkdp
approved these changes
May 16, 2025
| /// Note that this does not specialize generic classes, functions, or type aliases! That is a | ||
| /// different operation that is performed explicitly (via a subscript operation), or implicitly | ||
| /// via a call to the generic object. | ||
| #[must_use] |
Member
Author
There was a problem hiding this comment.
Clippy told me that #[must_use] on traits are useless :(
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the MSRV to 1.85 (according to our versioning policy) and the development Rust version to 1.87 (latest).
This PR does not switch to the Rust 2024 edition. I think it's better if we do this in a separate PR
Test Plan
cargo test