[pyupgrade] Add spaces between tokens as necessary to avoid syntax errors in UP018 autofix
#17648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors in `UP018` fix
Contributor
|
AlexWaygood
added
bug
LaBatata101
changed the title
pyupgrade] Add spaces between tokens as necessary to avoid syntax errors in UP018 fixpyupgrade] Add spaces between tokens as necessary to avoid syntax errors in UP018 autofix
MichaReiser
reviewed
May 3, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
I think what you did is fine. I'm somewhat inclined to instead look at the parent_expr but I can see that this might be harder (simply because we already use it in the check)
crates/ruff_linter/src/rules/pyupgrade/rules/native_literals.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/native_literals.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Micha Reiser <micha@reiser.io>
MichaReiser
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Is it better to add another edit in the fix to add the space, or this is fine?
https://github.com/LaBatata101/ruff/blob/032bd2edcb7a3576ac0a69fd193a675639b5ea0e/crates/ruff_linter/src/rules/pyupgrade/rules/native_literals.rs#L284-L286
Fixes #17606
Test Plan
Snapshot tests.