Skip to content

[red-knot] Move name field on parameter kind #16830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[red-knot] Move name field on parameter kind #16830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 64 additions & 34 deletions crates/red_knot_python_semantic/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,32 +2351,38 @@ impl<'db> Type<'db> {
Signature::new(
Parameters::new([
Parameter::new(
Some(Name::new_static("instance")),
Some(Type::none(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("instance")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("owner")),
Some(KnownClass::Type.to_instance(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("owner")),
default_ty: None,
},
),
]),
None,
),
Signature::new(
Parameters::new([
Parameter::new(
Some(Name::new_static("instance")),
Some(not_none),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("instance")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("owner")),
Some(UnionType::from_elements(
db,
[KnownClass::Type.to_instance(db), Type::none(db)],
)),
ParameterKind::PositionalOnly {
name: Some(Name::new_static("owner")),
default_ty: Some(Type::none(db)),
},
),
Expand All @@ -2402,42 +2408,52 @@ impl<'db> Type<'db> {
Signature::new(
Parameters::new([
Parameter::new(
Some(Name::new_static("self")),
Some(KnownClass::FunctionType.to_instance(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("self")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("instance")),
Some(Type::none(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("instance")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("owner")),
Some(KnownClass::Type.to_instance(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("owner")),
default_ty: None,
},
),
]),
None,
),
Signature::new(
Parameters::new([
Parameter::new(
Some(Name::new_static("self")),
Some(KnownClass::FunctionType.to_instance(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("self")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("instance")),
Some(not_none),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("instance")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("owner")),
Some(UnionType::from_elements(
db,
[KnownClass::Type.to_instance(db), Type::none(db)],
)),
ParameterKind::PositionalOnly {
name: Some(Name::new_static("owner")),
default_ty: Some(Type::none(db)),
},
),
Expand All @@ -2464,9 +2480,9 @@ impl<'db> Type<'db> {
self,
Signature::new(
Parameters::new([Parameter::new(
Some(Name::new_static("o")),
Some(Type::any()),
ParameterKind::PositionalOnly {
name: Some(Name::new_static("o")),
default_ty: Some(Type::BooleanLiteral(false)),
},
)]),
Expand All @@ -2489,9 +2505,9 @@ impl<'db> Type<'db> {
[
Signature::new(
Parameters::new([Parameter::new(
Some(Name::new_static("o")),
Some(Type::any()),
ParameterKind::PositionalOnly {
name: Some(Name::new_static("o")),
default_ty: Some(Type::string_literal(db, "")),
},
)]),
Expand All @@ -2500,19 +2516,25 @@ impl<'db> Type<'db> {
Signature::new(
Parameters::new([
Parameter::new(
Some(Name::new_static("o")),
Some(Type::any()), // TODO: ReadableBuffer
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("o")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("encoding")),
Some(KnownClass::Str.to_instance(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("encoding")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("errors")),
Some(KnownClass::Str.to_instance(db)),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("errors")),
default_ty: None,
},
),
]),
Some(KnownClass::Str.to_instance(db)),
Expand All @@ -2535,28 +2557,36 @@ impl<'db> Type<'db> {
[
Signature::new(
Parameters::new([Parameter::new(
Some(Name::new_static("o")),
Some(Type::any()),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("o")),
default_ty: None,
},
)]),
Some(KnownClass::Type.to_instance(db)),
),
Signature::new(
Parameters::new([
Parameter::new(
Some(Name::new_static("o")),
Some(Type::any()),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("o")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("bases")),
Some(Type::any()),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("bases")),
default_ty: None,
},
),
Parameter::new(
Some(Name::new_static("dict")),
Some(Type::any()),
ParameterKind::PositionalOnly { default_ty: None },
ParameterKind::PositionalOnly {
name: Some(Name::new_static("dict")),
default_ty: None,
},
),
]),
Some(KnownClass::Type.to_instance(db)),
Expand Down
Loading
Loading