[pylint] Improve repeated-equality-comparison fix to use a set when all elements are hashable (PLR1714)

[MichaReiser]

Summary

This PR promotes the fix improvements for PLR1714 that were introduced in #14372 to stable.

The improvement is that the fix now proposes to use a set if all elements are hashable:

foo == "bar" or foo == "baz" or foo == "qux"

Gets fixed to

foo in {"bar", "baz", "qux"}

where it previously always got fixed to a tuple.

The new fix was first released in ruff 0.8.0 (Nov last year). This is not a breaking change. The change was preview gated only to get some extra test coverage.

There are no open issues or PRs related to this changed fix behavior.

[codspeed-hq]

CodSpeed Performance Report

Merging #16685 will degrade performances by 4.61%

_{Comparing micha/repeated-equality-fix (b13b4d6) with micha/ruff-0.10 (5a40aee)}

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	red_knot_check_file[incremental]	5.2 ms	5.5 ms	-4.61%

[ntBre]

I think the part below this "and continue to suggest the use of a set" was also part of the preview behavior.

[MichaReiser]

Nice catch, yeah. I should have removed the continue

[github-actions]

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+31 -31 violations, +0 -0 fixes in 5 projects; 50 projects unchanged)

apache/airflow (+20 -20 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- airflow/api_fastapi/logging/decorators.py:66:27: PLR1714 Consider merging multiple comparisons: `k in ("val", "value")`. Use a `set` if the elements are hashable.
+ airflow/api_fastapi/logging/decorators.py:66:27: PLR1714 Consider merging multiple comparisons: `k in {"val", "value"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3070:8: PLR1714 Consider merging multiple comparisons: `package_format in ("sdist", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3070:8: PLR1714 Consider merging multiple comparisons: `package_format in {"sdist", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3072:8: PLR1714 Consider merging multiple comparisons: `package_format in ("wheel", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3072:8: PLR1714 Consider merging multiple comparisons: `package_format in {"wheel", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3088:8: PLR1714 Consider merging multiple comparisons: `package_format in ("sdist", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3088:8: PLR1714 Consider merging multiple comparisons: `package_format in {"sdist", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3090:8: PLR1714 Consider merging multiple comparisons: `package_format in ("wheel", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:3090:8: PLR1714 Consider merging multiple comparisons: `package_format in {"wheel", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:659:12: PLR1714 Consider merging multiple comparisons: `package_format in ("sdist", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:659:12: PLR1714 Consider merging multiple comparisons: `package_format in {"sdist", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:661:12: PLR1714 Consider merging multiple comparisons: `package_format in ("wheel", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:661:12: PLR1714 Consider merging multiple comparisons: `package_format in {"wheel", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:676:12: PLR1714 Consider merging multiple comparisons: `package_format in ("sdist", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:676:12: PLR1714 Consider merging multiple comparisons: `package_format in {"sdist", "both"}`.
- dev/breeze/src/airflow_breeze/commands/release_management_commands.py:678:12: PLR1714 Consider merging multiple comparisons: `package_format in ("wheel", "both")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/commands/release_management_commands.py:678:12: PLR1714 Consider merging multiple comparisons: `package_format in {"wheel", "both"}`.
- dev/breeze/src/airflow_breeze/utils/host_info_utils.py:39:8: PLR1714 Consider merging multiple comparisons: `os in ("linux", "darwin")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/utils/host_info_utils.py:39:8: PLR1714 Consider merging multiple comparisons: `os in {"linux", "darwin"}`.
- dev/breeze/src/airflow_breeze/utils/host_info_utils.py:49:8: PLR1714 Consider merging multiple comparisons: `os in ("linux", "darwin")`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/utils/host_info_utils.py:49:8: PLR1714 Consider merging multiple comparisons: `os in {"linux", "darwin"}`.
- dev/breeze/src/airflow_breeze/utils/packages.py:737:12: PLR1714 Consider merging multiple comparisons: `ex.returncode in (128, 2)`. Use a `set` if the elements are hashable.
+ dev/breeze/src/airflow_breeze/utils/packages.py:737:12: PLR1714 Consider merging multiple comparisons: `ex.returncode in {128, 2}`.
+ dev/breeze/src/airflow_breeze/utils/selective_checks.py:994:16: PLR1714 Consider merging multiple comparisons.
- dev/breeze/src/airflow_breeze/utils/selective_checks.py:994:16: PLR1714 Consider merging multiple comparisons. Use a `set` if the elements are hashable.
- helm_tests/airflow_aux/test_basic_helm_chart.py:82:12: PLR1714 Consider merging multiple comparisons: `version in ("2.3.2", "default")`. Use a `set` if the elements are hashable.
+ helm_tests/airflow_aux/test_basic_helm_chart.py:82:12: PLR1714 Consider merging multiple comparisons: `version in {"2.3.2", "default"}`.
- providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:2015:12: PLR1714 Consider merging multiple comparisons: `provider in ("github", "githublocal")`. Use a `set` if the elements are hashable.
+ providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:2015:12: PLR1714 Consider merging multiple comparisons: `provider in {"github", "githublocal"}`.
- providers/google/src/airflow/providers/google/common/hooks/base_google.py:114:16: PLR1714 Consider merging multiple comparisons: `exception.resp.status in (429, 409)`. Use a `set` if the elements are hashable.
+ providers/google/src/airflow/providers/google/common/hooks/base_google.py:114:16: PLR1714 Consider merging multiple comparisons: `exception.resp.status in {429, 409}`.
... 8 additional changes omitted for project

apache/superset (+4 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- superset/migrations/versions/2023-03-17_13-24_b5ea9d343307_bar_chart_stack_options.py:82:16: PLR1714 Consider merging multiple comparisons: `stack in ("Stack", "Stream")`. Use a `set` if the elements are hashable.
+ superset/migrations/versions/2023-03-17_13-24_b5ea9d343307_bar_chart_stack_options.py:82:16: PLR1714 Consider merging multiple comparisons: `stack in {"Stack", "Stream"}`.
- superset/migrations/versions/2024-05-10_18-02_f84fde59123a_update_charts_with_old_time_comparison.py:204:13: PLR1714 Consider merging multiple comparisons: `Slice.viz_type in ("pop_kpi", "table")`. Use a `set` if the elements are hashable.
+ superset/migrations/versions/2024-05-10_18-02_f84fde59123a_update_charts_with_old_time_comparison.py:204:13: PLR1714 Consider merging multiple comparisons: `Slice.viz_type in {"pop_kpi", "table"}`.
- superset/utils/core.py:314:13: PLR1714 Consider merging multiple comparisons: `standalone_param not in ("false", "0")`. Use a `set` if the elements are hashable.
+ superset/utils/core.py:314:13: PLR1714 Consider merging multiple comparisons: `standalone_param not in {"false", "0"}`.
- tests/integration_tests/databases/commands_tests.py:1187:12: PLR1714 Consider merging multiple comparisons: `database.backend in ("postgresql", "mysql")`. Use a `set` if the elements are hashable.
+ tests/integration_tests/databases/commands_tests.py:1187:12: PLR1714 Consider merging multiple comparisons: `database.backend in {"postgresql", "mysql"}`.

aws/aws-sam-cli (+1 -1 violations, +0 -0 fixes)

- tests/integration/publish/publish_app_integ_base.py:60:16: PLR1714 Consider merging multiple comparisons: `f.suffix in (".yaml", ".json")`. Use a `set` if the elements are hashable.
+ tests/integration/publish/publish_app_integ_base.py:60:16: PLR1714 Consider merging multiple comparisons: `f.suffix in {".yaml", ".json"}`.

bokeh/bokeh (+4 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- src/bokeh/core/has_props.py:280:24: PLR1714 Consider merging multiple comparisons: `head in ("bokeh", "__main__")`. Use a `set` if the elements are hashable.
+ src/bokeh/core/has_props.py:280:24: PLR1714 Consider merging multiple comparisons: `head in {"bokeh", "__main__"}`.
- src/bokeh/server/tornado.py:622:12: PLR1714 Consider merging multiple comparisons: `mode in ("server", "server-dev")`. Use a `set` if the elements are hashable.
+ src/bokeh/server/tornado.py:622:12: PLR1714 Consider merging multiple comparisons: `mode in {"server", "server-dev"}`.
- tests/unit/bokeh/embed/test_server__embed.py:215:16: PLR1714 Consider merging multiple comparisons: `r in ("&foo=10&bar=baz", "&bar=baz&foo=10")`. Use a `set` if the elements are hashable.
+ tests/unit/bokeh/embed/test_server__embed.py:215:16: PLR1714 Consider merging multiple comparisons: `r in {"&foo=10&bar=baz", "&bar=baz&foo=10"}`.
- tests/unit/bokeh/embed/test_server__embed.py:222:16: PLR1714 Consider merging multiple comparisons: `r in ("&foo=10&bar=baz", "&bar=baz&foo=10")`. Use a `set` if the elements are hashable.
+ tests/unit/bokeh/embed/test_server__embed.py:222:16: PLR1714 Consider merging multiple comparisons: `r in {"&foo=10&bar=baz", "&bar=baz&foo=10"}`.

latchbio/latch (+2 -2 violations, +0 -0 fixes)

- src/latch_cli/services/stop_pod.py:22:8: PLR1714 Consider merging multiple comparisons: `res.status_code in (403, 404)`. Use a `set` if the elements are hashable.
+ src/latch_cli/services/stop_pod.py:22:8: PLR1714 Consider merging multiple comparisons: `res.status_code in {403, 404}`.
- src/latch_cli/snakemake/single_task_snakemake.py:362:8: PLR1714 Consider merging multiple comparisons: `parsed.scheme not in ("", "docker")`. Use a `set` if the elements are hashable.
+ src/latch_cli/snakemake/single_task_snakemake.py:362:8: PLR1714 Consider merging multiple comparisons: `parsed.scheme not in {"", "docker"}`.

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PLR1714	62	31	31	0	0

Linter (preview)

✅ ecosystem check detected no linter changes.