[red-knot] Outline integration point for len diagnostics
#16124
+115
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
commented
Feb 12, 2025
| @@ -3344,6 +3344,10 @@ impl<'db> TypeInferenceBuilder<'db> { | |||
| }; | |||
| } | |||
| } | |||
|
|
|||
| KnownFunction::Len => { | |||
| // TODO: Assert that the argument implements the `Sized` protocol (correctly). | |||
There was a problem hiding this comment.
This probably requires calling __len__ to get the CallDunderLenOutcome and then verify the binding on it.
MichaReiser
commented
Feb 12, 2025
| match self.call_dunder(db, "__len__", &CallArguments::positional([*self])) { | ||
| CallDunderOutcome::MethodNotAvailable => CallDunderLenOutcome::MethodNotAvailable, | ||
| CallDunderOutcome::Call(outcome) => CallDunderLenOutcome::Call(outcome), | ||
| CallDunderOutcome::PossiblyUnbound(outcome) => { |
There was a problem hiding this comment.
What's slightly confusing here is that CallOutcome also has a PossiblyUnbound variant which can also be in the Call variant. I feel like we should only have one?
MichaReiser
force-pushed
the
micha/call-outcome-step2
branch
from
4c984a1 to
0232257
Compare
MichaReiser
force-pushed
the
micha/call-outcome-step2
branch
from
0232257 to
20cfc11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This step continues with what the first PR started by moving out type checking operations from the
Type::operations.I found
lenan interesting use case because it may lead to a fair amount of code duplication.I'm still not a 100% convinced by this approach because it can require performing some operations twice:
We could avoid some of that by adding more information to the
Outcomebut I'm not too much a fan of thatbecause it means larger return types for everyone.
Test Plan