[flake8-builtins] Remove builtins- prefix from option names
#16092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| S704 | 30 | 30 | 0 | 0 | 0 |
| RUF035 | 9 | 0 | 9 | 0 | 0 |
InSyncWithFoo
force-pushed
the
builtins-options
branch
2 times, most recently
from
0eb38e6 to
c163482
Compare
|
Thanks. I think the What we did in the past is to emit a deprecation warning for renamed settings so that we can remove the old names at some point in the future. It probably requires duplicating the fields on the |
|
As an additional reference, I think the infrastructure already exists and |
InSyncWithFoo
force-pushed
the
builtins-options
branch
3 times, most recently
from
5e78095 to
56895d5
Compare
InSyncWithFoo
force-pushed
the
builtins-options
branch
from
ff9406a to
f9e1f0f
Compare
MichaReiser
force-pushed
the
micha/ruff-0.10
branch
from
44eec2b to
e4e1c58
Compare
MichaReiser
force-pushed
the
builtins-options
branch
from
f063e5e to
257624f
Compare
MichaReiser
added a commit
that referenced
this pull request
Mar 13, 2025
## Summary Resolves #15368. The following options have been renamed: * `builtins-allowed-modules` → `allowed-modules` * `builtins-ignorelist` → `ignorelist` * `builtins-strict-checking` → `strict-checking` To preserve compatibility, the old names are kept as Serde aliases. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Micha Reiser <micha@reiser.io>
MichaReiser
added a commit
that referenced
this pull request
Mar 13, 2025
## Summary Resolves #15368. The following options have been renamed: * `builtins-allowed-modules` → `allowed-modules` * `builtins-ignorelist` → `ignorelist` * `builtins-strict-checking` → `strict-checking` To preserve compatibility, the old names are kept as Serde aliases. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Micha Reiser <micha@reiser.io>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15368.
The following options have been renamed:
builtins-allowed-modules→allowed-modulesbuiltins-ignorelist→ignorelistbuiltins-strict-checking→strict-checkingTo preserve compatibility, the old names are kept as Serde aliases.
Test Plan
cargo nextest runandcargo insta test.