[pylint] Fix PL1730: min/max auto-fix and suggestion

[VascoSch92]

Summary

The PR addresses the issue #15887

For two objects a and b, we ensure that the auto-fix and the suggestion is of the form a = min(a, b) (or a = max(a, b)). This is because we want to be consistent with the python implementation of the methods: min and max. See the above issue for more details.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[VascoSch92]

@MichaReiser I implemented your suggestion ;-) Let me know if you like it...

[MichaReiser]

Thanks. I think we can simplify this further.

[MichaReiser]

I think we can simplify this to (and also reduce the diff size):

    let min_max = match (
        left_is_target,
        right_is_target,
        left_is_value,
        right_is_value,
    ) {
        (true, false, false, true) => match op {
            CmpOp::Lt | CmpOp::LtE => MinMax::Max,
            CmpOp::Gt | CmpOp::GtE => MinMax::Min,
            _ => return,
        },
        (false, true, true, false) => match op {
            CmpOp::Lt | CmpOp::LtE => MinMax::Min,
            CmpOp::Gt | CmpOp::GtE => MinMax::Max,
            _ => return,
        },
        _ => return,
    };

		// Determine whether to use `min()` or `max()`, and make sure that the first
    // arg of the `min()` or `max()` method is equal to the target of the comparison.
    // This is to be consistent with the Python implementation of the methods `min()` and `max()`.
    let (arg1, arg2) = if left_is_target {
        (&**left, right)
    } else {
        (right, &**left)
    };

[VascoSch92]

Yes... I did the changes ;-)

[MichaReiser]

Nice, thank you