Add deprecation warning for ruff-lsp related settings - #15850
Merged
Conversation
dhruvmanila
force-pushed
the
dhruv/deprecate-editor-setting
branch
from
February 3, 2025 06:35
10df1a1 to
89c04f0
Compare
dhruvmanila
marked this pull request as ready for review
February 3, 2025 06:42
MichaReiser
approved these changes
Feb 3, 2025
MichaReiser
left a comment
MichaReiser
left a comment
Member
There was a problem hiding this comment.
Nice! We could consider grouping all deprecated settings in their own setting so that they appear less prominent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the documentation to add deprecated warning for
ruff-lspspecific settingsPreview
Screen.Recording.2025-02-03.at.12.07.41.PM.mov
Test Plan
Build the documentation locally and test out the links. Refer to the preview video above.