Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Consider all definitions after terminal statements unreachable #15676

Merged
merged 37 commits into from
Jan 29, 2025
Merged

[red-knot] Consider all definitions after terminal statements unreachable #15676

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
e0d2130
Add failing test cases for terminal control flow
dcreager Jan 22, 2025
f45af24
Record unreachable visibility after terminal statements
dcreager Jan 22, 2025
70b681b
More thorough reveal_types
dcreager Jan 22, 2025
81a3164
Actually we do support those now!
dcreager Jan 22, 2025
93b149c
Merge branch 'main' into dcreager/terminal-visibility
dcreager Jan 23, 2025
912ed62
Use happy constant
dcreager Jan 23, 2025
4102c89
Record reachability in semantic index builder
dcreager Jan 24, 2025
60eccc9
Apply suggestions from code review
dcreager Jan 24, 2025
4190b5b
Add (failing) eager subscope example
dcreager Jan 24, 2025
641ccb8
Also skip merging when lhs is unreachable
dcreager Jan 24, 2025
efdf6c3
We support this one too
dcreager Jan 24, 2025
57ea7ca
Add failing try/finally example
dcreager Jan 24, 2025
db98926
Use for loops
dcreager Jan 24, 2025
a434762
Add Carl's suggested return error
dcreager Jan 24, 2025
b9f91fb
Merge branch 'main' into dcreager/terminal-visibility
dcreager Jan 24, 2025
1388eb0
Merge branch 'main' into dcreager/terminal-visibility
dcreager Jan 27, 2025
79de3eb
Add failing early return example
dcreager Jan 27, 2025
c4d1599
Add TODOs for function return example
dcreager Jan 27, 2025
82e6e67
Add TODO link for continue false positives
dcreager Jan 27, 2025
bfe76da
Prefer the faster option first
dcreager Jan 27, 2025
0b7da66
Apply suggestions from code review
dcreager Jan 28, 2025
e4771bf
Better descriptions of continue and break; add nested tests
dcreager Jan 28, 2025
9431fb9
Remove tomllib benchmark error reproduction
dcreager Jan 28, 2025
08b0522
Add "both nested branches" tests
dcreager Jan 28, 2025
ee3ac28
Add separate then/else branch tests
dcreager Jan 28, 2025
add8a57
Fix comment
dcreager Jan 28, 2025
a0e6980
Remove duplicate test
dcreager Jan 28, 2025
9fb8d2a
Fix header
dcreager Jan 28, 2025
3684739
Add raise tests
dcreager Jan 28, 2025
7fbec5f
Add return-in-try tests
dcreager Jan 28, 2025
5c45e88
Fix comment
dcreager Jan 28, 2025
d2b21fc
Add statically-known terminal test case
dcreager Jan 28, 2025
2f62eb0
Apply suggestions from code review
dcreager Jan 29, 2025
32e8131
Update TODOs to not assume how we'll change exception tracking
dcreager Jan 29, 2025
2932bb4
Merge branch 'main' into dcreager/terminal-visibility
dcreager Jan 29, 2025
1cf65f5
Linter
dcreager Jan 29, 2025
681fae2
Update crates/red_knot_python_semantic/resources/mdtest/terminal_stat…
dcreager Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into dcreager/terminal-visibility 
* main:
  [red-knot] Extend instance-attribute tests (#15808)
  Fix formatter warning message for `flake8-quotes` option (#15788)
  [`flake8-bugbear`] Exempt `NewType` calls where the original type is immutable (`B008`) (#15765)
  Add missing config docstrings (#15803)
  [`refurb`] Do not emit diagnostic when loop variables are used outside loop body (`FURB122`) (#15757)
  [`ruff`] Check for shadowed `map` before suggesting fix (`RUF058`) (#15790)
  [red-knot] Do not use explicit `knot_extensions.Unknown` declaration (#15787)
  Preserve quotes in generated byte strings (#15778)
  [minor] Simplify some `ExprStringLiteral` creation logic (#15775)
  Preserve quote style in generated code (#15726)
  Rename internal helper functions (#15771)
  [`airflow`] Extend airflow context parameter check for `BaseOperator.execute` (`AIR302`) (#15713)
  Implement tab autocomplete for `ruff config` (#15603)
  • Loading branch information
@dcreager
dcreager committed Jan 29, 2025
commit 2932bb4f7d8273826fb7f7a70f9ce1e73c01d4ac

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.