Skip to content

Remove flatten to improve deserialization error messages - #15414

Merged
dhruvmanila merged 1 commit into
mainfrom
dhruv/flatten-options
Jan 11, 2025
Merged

Remove flatten to improve deserialization error messages#15414
dhruvmanila merged 1 commit into
mainfrom
dhruv/flatten-options

Conversation

@dhruvmanila

@dhruvmanila dhruvmanila commented Jan 11, 2025

Copy link
Copy Markdown
Member

Summary

Closes: #9719

Test Plan

Before:

ruff failed
  Cause: Failed to parse /Users/dhruv/playground/ruff/pyproject.toml
  Cause: TOML parse error at line 22, column 1
   |
22 | [tool.ruff.lint]
   | ^^^^^^^^^^^^^^^^
invalid type: string "false", expected a boolean

After:

ruff failed
  Cause: Failed to parse /Users/dhruv/playground/ruff/pyproject.toml
  Cause: TOML parse error at line 27, column 20
   |
27 | mypy-init-return = "false"
   |                    ^^^^^^^
invalid type: string "false", expected a boolean

@dhruvmanila
dhruvmanila force-pushed the dhruv/flatten-options branch from 44bef26 to 8235836 Compare January 11, 2025 06:26
@dhruvmanila dhruvmanila added the configuration Related to settings and configuration label Jan 11, 2025
@github-actions

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@dhruvmanila
dhruvmanila marked this pull request as ready for review January 11, 2025 16:37
@dhruvmanila
dhruvmanila merged commit 38f873b into main Jan 11, 2025
@dhruvmanila
dhruvmanila deleted the dhruv/flatten-options branch January 11, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration Related to settings and configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOML parse error source reference is unhelpful

2 participants