Remove the optional salsa dependency from the AST crate - #14363
Merged
Conversation
MichaReiser
requested review from
AlexWaygood,
carljm and
sharkdp
as code owners
November 15, 2024 16:40
MichaReiser
enabled auto-merge (squash)
November 15, 2024 16:44
MichaReiser
deleted the
micha/parser-remove-optional-salsa-dependency
branch
November 15, 2024 16:46
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I added the
Lookupimplementation toNameto allowClassandFunctionTypelookups with a&str.What I didn't realize is that all lookups have a
&Namereference. We never have a case where we just have a&str.That's why I'm removing the
Lookupimplementation because I prefer ifruff-python-astdoesn't depend on salsa, even if optionally.Test Plan
cargo test