Skip to content

Remove the optional salsa dependency from the AST crate - #14363

Merged
MichaReiser merged 1 commit into
mainfrom
micha/parser-remove-optional-salsa-dependency
Nov 15, 2024
Merged

Remove the optional salsa dependency from the AST crate#14363
MichaReiser merged 1 commit into
mainfrom
micha/parser-remove-optional-salsa-dependency

Conversation

@MichaReiser

Copy link
Copy Markdown
Member

Summary

I added the Lookup implementation to Name to allow Class and FunctionType lookups with a &str.
What I didn't realize is that all lookups have a &Name reference. We never have a case where we just have a &str.

That's why I'm removing the Lookup implementation because I prefer if ruff-python-ast doesn't depend on salsa, even if optionally.

Test Plan

cargo test

@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Nov 15, 2024
@MichaReiser
MichaReiser enabled auto-merge (squash) November 15, 2024 16:44
@MichaReiser
MichaReiser merged commit 2b58705 into main Nov 15, 2024
@MichaReiser
MichaReiser deleted the micha/parser-remove-optional-salsa-dependency branch November 15, 2024 16:46
@github-actions

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant